Skip to content

refactor(agents): reorganize AI artifacts from hve-core into shared collection subdirectories#917

Draft
peterbryntesson wants to merge 2 commits intomicrosoft:mainfrom
peterbryntesson:feature/issue-643
Draft

refactor(agents): reorganize AI artifacts from hve-core into shared collection subdirectories#917
peterbryntesson wants to merge 2 commits intomicrosoft:mainfrom
peterbryntesson:feature/issue-643

Conversation

@peterbryntesson
Copy link
Contributor

@peterbryntesson peterbryntesson commented Mar 6, 2026

Pull Request

Description

Reorganizes AI artifacts from flat hve-core/ directories into collection-aligned subdirectories, implementing part of the directory restructuring effort described in #643. The primary changes are:

  • Agents: Renames .github/agents/hve-core/ to .github/agents/shared/ and .github/agents/code-review/ to .github/agents/coding-standards/
  • Instructions: Renames .github/instructions/hve-core/ to .github/instructions/shared/ (commit-message, git-merge, markdown, prompt-builder, pull-request, writing-style)
  • Instructions: Moves story-quality.instructions.md from shared/ to project-planning/
  • Prompts: Renames .github/prompts/code-review/ to .github/prompts/coding-standards/
  • Cross-references: Updates all internal path references in moved files, copilot-instructions.md, and instructions/README.md

Related Issue(s)

Partial implementation of #643

Type of Change

Select all that apply:

Code & Documentation:

  • Bug fix (non-breaking change fixing an issue)
  • New feature (non-breaking change adding functionality)
  • Breaking change (fix or feature causing existing functionality to change)
  • Documentation update

Infrastructure & Configuration:

  • GitHub Actions workflow
  • Linting configuration (markdown, PowerShell, etc.)
  • Security configuration
  • DevContainer configuration
  • Dependency update

AI Artifacts:

  • Reviewed contribution with prompt-builder agent and addressed all feedback
  • Copilot instructions (.github/instructions/*.instructions.md)
  • Copilot prompt (.github/prompts/*.prompt.md)
  • Copilot agent (.github/agents/*.agent.md)
  • Copilot skill (.github/skills/*/SKILL.md)

Note for AI Artifact Contributors:

  • Agents: Research, indexing/referencing other project (using standard VS Code GitHub Copilot/MCP tools), planning, and general implementation agents likely already exist. Review .github/agents/ before creating new ones.
  • Skills: Must include both bash and PowerShell scripts. See Skills.
  • Model Versions: Only contributions targeting the latest Anthropic and OpenAI models will be accepted. Older model versions (e.g., GPT-3.5, Claude 3) will be rejected.
  • See Agents Not Accepted and Model Version Requirements.

Other:

  • Other (please describe): Repository directory restructuring for collection-aligned organization

Testing

  • Verify renamed files are accessible at new paths
  • Confirm internal cross-references resolve correctly
  • Run npm run lint:md and npm run lint:frontmatter to validate file integrity

Checklist

Required Checks

  • Documentation is updated (if applicable)
  • Files follow existing naming conventions
  • Changes are backwards compatible (if applicable)
  • Tests added for new functionality (if applicable)

AI Artifact Contributions

  • Used /prompt-analyze to review contribution
  • Addressed all feedback from prompt-builder review
  • Verified contribution follows common standards and type-specific requirements

Required Automated Checks

The following validation commands must pass before merging:

  • Markdown linting: npm run lint:md
  • Spell checking: npm run spell-check
  • Frontmatter validation: npm run lint:frontmatter
  • Skill structure validation: npm run validate:skills
  • Link validation: npm run lint:md-links
  • PowerShell analysis: npm run lint:ps
  • Plugin freshness: npm run plugin:generate

Security Considerations

  • This PR does not contain any sensitive or NDA information
  • Any new dependencies have been reviewed for security issues
  • Security-related scripts follow the principle of least privilege

Additional Notes

This is a draft PR implementing a subset of #643. The reorganization renames the hve-core and code-review collection directories to shared and coding-standards respectively, aligning with the collection-based directory structure. Collection YAML manifests and plugin outputs may need regeneration after these renames.

Recommended validation before marking ready for review:

  • Test prompts against relevant scenarios
  • Verify instructions applyTo patterns remain correct after path changes
  • Confirm agent agents: frontmatter references resolve via glob paths

- move functional-code-review agent and prompt from code-review/ to coding-standards/
- move story-quality instructions from shared/ to project-planning/
- update collection manifests, plugins, settings, and docs for new paths
- pin markdown-table-formatter and markdownlint-cli2 versions

🔧 - Generated by Copilot
- rename agents from .github/agents/hve-core/ to .github/agents/shared/
- rename instructions from .github/instructions/hve-core/ to .github/instructions/shared/
- update all cross-references in prompts, skills, collections, and configs

📂 - Generated by Copilot
@WilliamBerryiii WilliamBerryiii changed the title Feature/issue 643 refactor(agents): reorganize AI artifacts from hve-core into shared collection subdirectories Mar 7, 2026
@WilliamBerryiii
Copy link
Member

Hey @peterbryntesson — thanks for picking up the directory reorganization work from #643! 🗂️ We've updated the PR title to follow our conventional commits format and filled in the description template to capture the scope of the renames and cross-reference updates. No action needed on your end.

@WilliamBerryiii
Copy link
Member

We've updated the PR description to align with the current pull request template. All original content has been preserved and relocated into the appropriate template sections. No action needed on your end — though you're welcome to review the updated description and fill in any remaining sections (testing details, checklist confirmations, etc.) at your convenience.

@WilliamBerryiii
Copy link
Member

Hi @stablegenius49 — Thanks for this contribution toward #643! Since this PR implements a subset of that issue's scope, could you please update #643 with a status comment once this PR merges? That way the team can track which parts of the original issue are complete and what remains. Appreciate it! 🙏

@katriendg
Copy link
Contributor

@peterbryntesson the re-organization of the agents and other artifacts has been completed, so probably the issue itself needs to be re-evaluated (as it was a bigger scope), and closed. Are you OK we close this one out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants