Skip to content

Dev/haonanttt/rich tab infra - #564

Draft
haonanttt wants to merge 11 commits into
mainfrom
dev/haonanttt/richTabInfra
Draft

Dev/haonanttt/rich tab infra#564
haonanttt wants to merge 11 commits into
mainfrom
dev/haonanttt/richTabInfra

Conversation

@haonanttt

Copy link
Copy Markdown
Contributor

Summary of the Pull Request

References and Relevant Issues

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

PR Checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated
    • If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated (if necessary)

L"LOCALAPPDATA",
L"PATH",
L"PATHEXT",
L"PROGRAMDATA",
L"PROGRAMDATA",
L"PROGRAMFILES",
L"PROGRAMFILES(X86)",
L"PSMODULEPATH",
L"PROGRAMFILES",
L"PROGRAMFILES(X86)",
L"PSMODULEPATH",
L"SYSTEMDRIVE",
if (!MoveFileExW(
temporary.c_str(),
target.c_str(),
MOVEFILE_REPLACE_EXISTING | MOVEFILE_WRITE_THROUGH))
if (!MoveFileExW(
temporary.c_str(),
target.c_str(),
MOVEFILE_REPLACE_EXISTING | MOVEFILE_WRITE_THROUGH))
[IO.File]::ReadAllText($config.FullName)
}
if ($configText -match '(?im)^\s*\[\s*include(?:if)?(?:\s|\])' -or
$configText -match '(?im)^\s*worktreeconfig\s*=') {
foreach ($name in $gitEnvironmentVariables) {
Remove-Item "Env:$name" -ErrorAction SilentlyContinue
}
$env:GIT_ATTR_NOSYSTEM = '1'
$env:GIT_ATTR_NOSYSTEM = '1'
$env:GIT_CONFIG_COUNT = '0'
$env:GIT_CONFIG_GLOBAL = 'NUL'
$env:GIT_CONFIG_NOSYSTEM = '1'
$gitOptions = @(
'--no-optional-locks'
'-c'
'core.fsmonitor=false'
request.processEpoch = 7;
request.sessionId = "session-id";
request.reason = ActivationEvent::WorkingDirectoryChanged;
request.workingDirectory = LR"(C:\repo)";
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: f3fe5c6d-38f4-4616-ab31-34e557403964
TEST_METHOD(ManagedProviderLifecycleAndIntegrity);
TEST_METHOD(ChangedManagedUpdateIsDisabled);
TEST_METHOD(DevelopmentRegistrationRemainsMutable);
TEST_METHOD(DevelopmentConsentDoesNotFollowAChangedRoot);
VERIFY_IS_TRUE(std::filesystem::exists(directories.source / L"provider.ps1"));
}

void RichTabProviderRegistryTests::DevelopmentConsentDoesNotFollowAChangedRoot()
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown

check-spelling-bot Report

⚠️ Dictionary not found

Problems were encountered retrieving check dictionaries (cspell:dart/src/dart.txt cspell:cpp/src/lang-jargon.txt cspell:dotnet/dict/dotnet.txt cspell:typescript/dict/typescript.txt cspell:sql/src/sql.txt cspell:django/dict/django.txt cspell:rust/dict/rust.txt cspell:latex/dict/latex.txt cspell:cpp/src/stdlib-cerrno.txt cspell:software-terms/dict/webServices.txt cspell:r/src/r.txt cspell:redis/dict/redis.txt cspell:fullstack/dict/fullstack.txt cspell:cpp/src/lang-keywords.txt cspell:lua/dict/lua.txt cspell:cpp/src/compiler-clang-attributes.txt cspell:elixir/dict/elixir.txt cspell:public-licenses/src/additional-licenses.txt cspell:docker/src/docker-words.txt cspell:cpp/src/stdlib-c.txt cspell:public-licenses/src/generated/public-licenses.txt cspell:cpp/src/template-strings.txt cspell:ada/dict/ada.txt cspell:scala/dict/scala.txt cspell:cpp/src/ecosystem.txt cspell:k8s/dict/k8s.txt cspell:cpp/src/people.txt cspell:cpp/src/compiler-msvc.txt cspell:svelte/dict/svelte.txt cspell:node/dict/node.txt cspell:python/src/common/extra.txt cspell:java/src/java-terms.txt cspell:java/src/java.txt cspell:python/src/python/python-lib.txt cspell:powershell/dict/powershell.txt cspell:cpp/src/stdlib-cpp.txt cspell:php/dict/php.txt cspell:software-terms/dict/softwareTerms.txt cspell:clojure/src/clojure.txt cspell:npm/dict/npm.txt cspell:css/dict/css.txt cspell:cpp/src/compiler-gcc.txt cspell:cpp/src/stdlib-cmath.txt cspell:shell/dict/shell-all-words.txt cspell:sql/src/tsql.txt cspell:monkeyc/src/monkeyc_keywords.txt cspell:ruby/dict/ruby.txt cspell:swift/src/swift.txt cspell:html/dict/html.txt cspell:python/src/python/python.txt cspell:haskell/dict/haskell.txt cspell:gaming-terms/dict/gaming-terms.txt cspell:golang/dict/go.txt cspell:python/src/additional_words.txt).

⚠️ For more information, see check-dictionary-not-found.

🔴 Please review

See the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.

Unrecognized words (10)

AChanged
commondir
epo
fsmonitor
MOVEFILE
NOSYSTEM
PROGRAMDATA
PSMODULEPATH
SYSTEMDRIVE
worktreeconfig

These words are not needed and should be removed AHP aiu Backgrounder CANTCALLOUT Ccc cplusplus ctl Debian depl dotnet drv endptr EOFs evt frob frobnicate Fullwidth gitlab hdr idl IME inbox ININPUTSYNCCALL INJ intelligentterminal Ioctl KVM lbl lld lsb NODEFAULT NONINFRINGEMENT notif oss outdir Podcast pri prioritization rcv segfault SND sourced SWP Tbl testname transitioning unk unparseable unregisters Virt VMs webpage websites WINVER WSLENV xsi

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the git@github.com:microsoft/intelligent-terminal.git repository
on the dev/haonanttt/richTabInfra branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/cfb6f7e75bbfc89c71eaa30366d0c166f1bd9c8c/apply.pl' |
perl - 'https://github.com/microsoft/intelligent-terminal/actions/runs/32090213704/attempts/1' &&
git commit -m 'Update check-spelling metadata'
Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (2100) from .github/actions/spelling/expect/alphabet.txt .github/actions/spelling/expect/expect.txt .github/actions/spelling/expect/web.txt and unrecognized words (10)

Dictionary Entries Covers Uniquely
cspell:csharp/csharp.txt 32 2 2
cspell:aws/aws.txt 232 2 2
cspell:fonts/fonts.txt 536 1 1

Consider adding to the extra_dictionaries array (in the .github/actions/spelling/config.json file):

    "cspell:csharp/csharp.txt",
    "cspell:aws/aws.txt",
    "cspell:fonts/fonts.txt",

To stop checking additional dictionaries, put (in the .github/actions/spelling/config.json file):

"check_extra_dictionaries": []

Pattern suggestions ✂️ (1)

You could add these patterns to .github/actions/spelling/patterns/9c27378ea5ce853b28ae7df1e5a01dc9bf3d4cbe.txt:

# Automatically suggested patterns

# hit-count: 1 file-count: 1
# container images
image: [-\w./:@]+

Alternatively, if a pattern suggestion doesn't make sense for this project, add a # to the beginning of the line in the candidates file with the pattern to stop suggesting it.

Warnings and Notices ⚠️ (2)

See the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.

⚠️ Warnings and Notices Count
ℹ️ candidate-pattern 1
⚠️ check-dictionary-not-found 54

See ⚠️ Event descriptions for more information.

✏️ Contributor please read this

By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.

If the listed items are:

  • ... misspelled, then please correct them instead of using the command.
  • ... names, please add them to .github/actions/spelling/allow/names.txt.
  • ... APIs, you can add them to a file in .github/actions/spelling/allow/.
  • ... just things you're using, please add them to an appropriate file in .github/actions/spelling/expect/.
  • ... tokens you only need in one place and shouldn't generally be used, you can add an item in an appropriate file in .github/actions/spelling/patterns/.

See the README.md in each directory for more information.

🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants