Migrate Azure.Mcp.Tools.Speech.LiveTests to recorded tests #1346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated FastTranscriptionRecognizer to use CreateClient() instead of DefaultClient - Re-parented SpeechCommandTests from CommandTestsBase to RecordedCommandTestsBase - Added assets.json file for recording management - Added sanitizers for subscription IDs, auth tokens, and cognitive services endpoints Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
scbedd
reviewed
Dec 10, 2025
tools/Azure.Mcp.Tools.Speech/src/Services/Recognizers/FastTranscriptionRecognizer.cs
Outdated
Show resolved
Hide resolved
Copilot
AI
changed the title
[WIP] Migrate Azure.Mcp.Tools.Speech.LiveTests to recorded tests
Migrate Azure.Mcp.Tools.Speech.LiveTests to recorded tests
Dec 10, 2025
…onRecognizer Updated per copilot instructions to use IHttpClientFactory.CreateClient() for proper test proxy recording support. Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
scbedd
reviewed
Dec 10, 2025
tools/Azure.Mcp.Tools.Speech/src/Services/Recognizers/FastTranscriptionRecognizer.cs
Show resolved
Hide resolved
Contributor
|
If you check out RealtimeTtsSynthesizer and RealtimeTranscriptionRecognizer they are both websockets, not recordable. I need to add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrates Speech LiveTests to use the recorded test infrastructure, enabling playback without live Azure resources.
Changes:
IHttpClientServicewithIHttpClientFactoryper copilot instructions to enable proper test proxy recording support. UsesIHttpClientFactory.CreateClient()method for HTTP client instantiation.CommandTestsBasetoRecordedCommandTestsBasewith sanitizers for:Azure.Mcp.Tools.Speech.LiveTestsfor recording managementRecordings will be populated separately per agent instructions.
GitHub issue number?
#1300