Skip to content

Conversation

@hallipr
Copy link
Member

@hallipr hallipr commented Dec 12, 2025

What does this PR do?

Publishes symbols during release

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Updated servers/Azure.Mcp.Server/CHANGELOG.md and/or servers/Fabric.Mcp.Server/CHANGELOG.md for product changes (features, bug fixes, UI/UX, updated dependencies)
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes using script at eng/scripts/Process-PackageReadMe.ps1. See Package README
    • Updated command list in /servers/Azure.Mcp.Server/docs/azmcp-commands.md and/or /docs/fabric-commands.md
    • Run .\eng\scripts\Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated test prompts in /servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds symbol publishing capability to the release pipeline. Symbols are debugging files (.pdb files) that help developers debug binaries in production environments. The changes integrate a new symbol publishing job into the existing release workflow.

Key Changes

  • Integrates symbol publishing into the release stage after the GitHub release tag is created
  • Creates a new pipeline job template that downloads signed binaries, publishes their symbols to Microsoft's symbol server, and archives the published symbols as a pipeline artifact

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
eng/pipelines/templates/jobs/release.yml Adds template inclusion for the new publish-symbols job into the release workflow
eng/pipelines/templates/jobs/publish-symbols.yml New job template that handles downloading signed binaries, publishing symbols via azure-sdk-build-tools, and archiving the results

@hallipr hallipr force-pushed the users/pahallis/publish-symbols branch from 226b1e8 to 801ffa3 Compare December 17, 2025 00:37
@hallipr hallipr marked this pull request as draft December 17, 2025 22:05
@hallipr
Copy link
Member Author

hallipr commented Dec 17, 2025

This PR needs to wait on clarification from MSRC on how to publish portable symbols for single-file executables. Currently, we end up with a folder full of pdbs and a single .exe. To convert the portable pdbs to windows pdbs for upload, each symbols file needs a dll.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants