Open
Conversation
microsoft-github-policy-service
bot
added
the
needs-triage
godlytalias
reviewed
Mar 11, 2026
specs/XamlBindingHelper_Spec.md
Outdated
|
|
||
| ### Remarks | ||
|
|
||
| * `dependencyObject` must not be `null`; an `E_POINTER` error is returned if it is `null`. |
Contributor
There was a problem hiding this comment.
Return type seems to be void
Author
There was a problem hiding this comment.
Updated it to - If dependencyObject or propertyToSet is null, an exception is thrown by the WinRT layer from the underlying E_POINTER failure
godlytalias
reviewed
Mar 11, 2026
| // Existing members omitted for brevity | ||
|
|
||
| [contract(Microsoft.UI.Xaml.WinUIContract, 10)] | ||
| [static_name("Microsoft.UI.Xaml.ISetterStatics2")] |
Contributor
There was a problem hiding this comment.
Why ISetterStatics2 is required? I think it can be ISetterStatics only
Author
There was a problem hiding this comment.
ISetterStatics2 is created by codegen likely because ValueProperty is in new contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
PR Type
Please check the type of change your PR introduces:
Description
Current Behavior
New Behavior
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):