Update Adv Logger Info to V6 [Rebase & FF] #826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
os-d
approved these changes
Feb 6, 2026
Member
Author
|
For those aware of Patina, it also tracks the advanced logger info version. An update will be made there to support v6. |
makubacki
force-pushed
the
clarify_adv_logger_versioning
branch
from
4359f18 to
38e742d
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/202502 #826 +/- ##
================================================
Coverage ? 4.71%
================================================
Files ? 36
Lines ? 4199
Branches ? 276
================================================
Hits ? 198
Misses ? 3999
Partials ? 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Currrently, ADVANCED_LOGGER_INFO_VER is being used to set and check the version field in the ADVANCED_LOGGER_INFO struct. This more clearly defines that version to be associated with the log info structure and breaks out the Hardware Level version to a macro (ADVANCED_LOGGER_INFO_HW_LVL_SUPPORTED_VER) that clearly shows that is an identifier for hardware level support being present in the logger info version. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
force-pushed
the
clarify_adv_logger_versioning
branch
from
38e742d to
b47d5aa
Compare
apop5
approved these changes
Feb 7, 2026
5 tasks
Member
Author
|
Note: Waiting for Arm platform testing before merging this. |
Updates the major version to 6 to account for the `NewLoggerInfoAddress` field that was added to `ADVANCED_LOGGER_INFO`. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
force-pushed
the
clarify_adv_logger_versioning
branch
from
b47d5aa to
b752c6b
Compare
Member
Author
Done |
os-d
approved these changes
Feb 10, 2026
makubacki
added a commit
to OpenDevicePartnership/patina
that referenced
this pull request
Feb 10, 2026
## Description Support using the v6 logger info structure for the advanced logger. Previously, only v5 was supported, in this change only v6 is supported. A future change may add support for both. - [x] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested - Verify advanced logger HOB is loaded during initialization - Dump memory log at EFI shell to verify log contents ## Integration Instructions - This must be paired with the V6 logger changes in microsoft/mu_plus#826 Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AdvLoggerPkg: Define a single advanced logger info version
Currrently, ADVANCED_LOGGER_INFO_VER is being used to set and check
the version field in the ADVANCED_LOGGER_INFO struct.
This more clearly defines that version to be associated with the
log info structure and breaks out the Hardware Level version to a
macro (ADVANCED_LOGGER_INFO_HW_LVL_SUPPORTED_VER) that clearly shows
that is an identifier for hardware level support being present in
the logger info version.
AdvLoggerPkg: Bump ADVANCED_LOGGER_INFO_VER to 6
Updates the major version to 6 to account for the
NewLoggerInfoAddressfield that was added to
ADVANCED_LOGGER_INFO.How This Was Tested
Integration Instructions