Skip to content

[Isolation Session] State aware tests now correctly check stderr for malformed_id - #1325

Merged
Elliot (theelliotm) merged 1 commit into
mainfrom
user/emichlin/iso-test-stale
Sep 29, 2026
Merged

Elliot (theelliotm) merged 1 commit into
mainfrom
user/emichlin/iso-test-stale

Conversation

@theelliotm

@theelliotm Elliot (theelliotm) commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

📖 Description

The malformed_id state aware test went stale during PR #1308, which deliberately moved non-dry-run exec error envelopes from stdout to stderr. This PR makes the test now correctly check stderr for malformed_id during actual execution, while still checking stdout during other phases.

🔗 References

Resolves #1324

🔍 Validation

✅ Checklist

📋 Issue Type

  • Bug fix
  • Feature
  • Task
Microsoft Reviewers: Open in CodeFlow

Copilot AI balanced review requested due to automatic review settings September 29, 2026 18:14
@theelliotm
Elliot (theelliotm) requested a review from a team as a code owner September 29, 2026 18:14
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused test fix matches the documented executor behavior and preserves existing handling for all other phases.

Review effort: Balanced
Findings: None

What changed in this PR

Updates the IsolationSession state-aware test to follow the phase-aware error stream contract.

Changes:

  • Parses real exec failure envelopes from stderr.
  • Continues parsing other phases and dry-run failures from stdout.
File Description
tests/​scripts/​run_isolation_session_state_aware_tests.ps1 Corrects malformed_id envelope parsing for real exec requests.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@adpa-ms

adpa-ms commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

[AgentAssisted] Validated this fix on a test machine with the IsolationSession service (x64), running tests/scripts/run_isolation_session_state_aware_tests.ps1 against a wxc-exec built from main at b6378934 (this PR's base) with the isolation_session feature:

  • Without the fix: 69/70 passed. The only failure was exec (real): error.code is 'malformed_id' (got '<no envelope>'), matching the nightly.
  • With a logically identical change (the same condition on one line): 70/70 passed, and that assertion reports (got 'malformed_id').

The Scheduled Validation Tests workflow, limited to the isolation-session jobs and run on a branch with that change, passed on x64 and arm64, including state-aware 70/70: https://github.com/microsoft/mxc/actions/runs/36610370509

@theelliotm
Elliot (theelliotm) merged commit ca5e901 into main Sep 29, 2026
30 of 32 checks passed
@theelliotm
Elliot (theelliotm) deleted the user/emichlin/iso-test-stale branch September 29, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[IsolationSession] State-aware E2E reads the real-exec malformed_id envelope from stdout after #1308 moved it to stderr

3 participants