Repository navigation
[Isolation Session] State aware tests now correctly check stderr for malformed_id - #1325
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused test fix matches the documented executor behavior and preserves existing handling for all other phases.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the IsolationSession state-aware test to follow the phase-aware error stream contract.
Changes:
- Parses real
execfailure envelopes from stderr. - Continues parsing other phases and dry-run failures from stdout.
| File | Description |
|---|---|
tests/scripts/run_isolation_session_state_aware_tests.ps1 |
Corrects malformed_id envelope parsing for real exec requests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
[AgentAssisted] Validated this fix on a test machine with the IsolationSession service (x64), running
The Scheduled Validation Tests workflow, limited to the isolation-session jobs and run on a branch with that change, passed on x64 and arm64, including state-aware 70/70: https://github.com/microsoft/mxc/actions/runs/36610370509 |
📖 Description
The
malformed_idstate aware test went stale during PR #1308, which deliberately moved non-dry-run exec error envelopes from stdout to stderr. This PR makes the test now correctly check stderr formalformed_idduring actual execution, while still checking stdout during other phases.🔗 References
Resolves #1324
🔍 Validation
✅ Checklist
Cargo.lock, thedependency-feed-checkcheck passes (see docs/pull-requests.md)📋 Issue Type
Microsoft Reviewers: Open in CodeFlow