Repository navigation
Retire pre-v0.9 LXC network paths - #1423
Closed
Gudge (MGudgin) wants to merge 1 commit into
Closed
Gudge (MGudgin) wants to merge 1 commit into
Gudge (MGudgin) wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Oct 6, 2026
Gudge (MGudgin)
force-pushed
the
user/gudge/retire-network-windows-vm
branch
from
October 6, 2026 21:54
600b82c to
2544f21
Compare
Gudge (MGudgin)
force-pushed
the
user/gudge/retire-network-lxc
branch
from
October 6, 2026 21:54
d4e3b63 to
dc5aef1
Compare
This PR removes unreachable LXC host-list and proxy routing and lowers directional CIDRs through typed rules. Reused containers check for stale proxy pins inside the container before launching workloads. Details * Reject unsupported network policy before container creation. * Remove old host routing while retaining in-container pin cleanup. * Document the supported directional-only LXC posture. Tests * cargo fmt --all -- --check and cargo test --workspace --quiet: passed. * cargo check --workspace --all-targets --all-features --quiet: passed. * cargo clippy --workspace --all-targets --all-features --quiet -- -D warnings: passed. * LXC units: 284 passed on Windows, 303 passed on Linux. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7570a662-a429-46d2-aa24-47fae6655cc4 Generated-with: gpt-6-sol
Gudge (MGudgin)
force-pushed
the
user/gudge/retire-network-windows-vm
branch
from
October 6, 2026 23:01
2544f21 to
d4d9e17
Compare
Gudge (MGudgin)
force-pushed
the
user/gudge/retire-network-lxc
branch
from
October 6, 2026 23:05
dc5aef1 to
6117179
Compare
Member
Author
|
Superseded by merged #1397, which includes the LXC cleanup in this stacked PR. Closing this alternative PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
This PR removes unreachable pre-v0.9 LXC host-list and proxy routing while keeping supported directional CIDR enforcement. Reused containers check and clear stale proxy pins inside the container before launching a workload.
Details
🔗 References
Depends on #1422. The live LXC workflow is main-target-only; this stacked PR needs a manual dispatch.
🔍 Validation
Tests
src/,cargo fmt --all -- --check: passed.cargo check --workspace --all-targets --all-features --quiet: passed.cargo clippy --workspace --all-targets --all-features --quiet -- -D warnings: passed.cargo test --workspace --quiet: passed.cargo test -p mxc-sdk --lib lxc::common --quiet: 284 passed on Windows.src/,cargo check -p mxc-sdk --all-targets --quiet: passed.cargo test -p mxc-sdk --lib lxc::common --quiet -- --test-threads=1: 303 passed.lxc-e2e.ymldispatch.✅ Checklist
Cargo.lock, thedependency-feed-checkcheck passes (see docs/pull-requests.md)📋 Issue Type
GitHub Actions runs the PR validation build automatically. The ADO pipeline
(
MXC-PR-Build) is the Azure version of the PR pipeline, kept in parity with the GitHubActions build; it runs on merge to
main, and Microsoft reviewers with write access can trigger iton a PR with
/azp run. See docs/pull-requests.md.If the
dependency-feed-checkcheck fails on a new dependency, the crate must be added tothe feed before the PR can pass. See docs/pull-requests.md
for the steps.
Microsoft Reviewers: Open in CodeFlow