Repository navigation
Remove remaining pre-v0.9 runtime vestiges - #1426
Closed
Gudge (MGudgin) wants to merge 1 commit into
Closed
Gudge (MGudgin) wants to merge 1 commit into
Gudge (MGudgin) wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Oct 6, 2026
Gudge (MGudgin)
force-pushed
the
user/gudge/retire-network-unix
branch
from
October 6, 2026 21:54
ee02978 to
f3e7a1a
Compare
Gudge (MGudgin)
force-pushed
the
user/gudge/retire-network-final-slice
branch
from
October 6, 2026 21:54
5102a7a to
bd0f149
Compare
This PR removes the remaining obsolete runtime network fields and built-in test proxy after the backends adopt supported directional policy. It keeps caller-managed proxy behavior and fails closed on unsafe diagnostics. Details * Remove shared fields, ownerless Unix coordinator and retired CLI flag. * Simplify ProcessContainer ownership and preserve network audits. * Redact non-string proxy diagnostics and correct WSLc guidance. Tests * Rust format, all-feature check, strict Clippy and workspace tests passed. * Feature suite: 3293 passed, 3 ignored; redaction regression passed. * Linux LXC/Bubblewrap: 603 passed; directional host suite passed. * macOS target check and schema codegen passed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7570a662-a429-46d2-aa24-47fae6655cc4 Generated-with: gpt-6-sol
Gudge (MGudgin)
force-pushed
the
user/gudge/retire-network-final-slice
branch
from
October 6, 2026 21:57
bd0f149 to
b551af1
Compare
Member
Author
|
Superseded by merged #1397, which includes the final shared-model and proxy cleanup in this stacked PR. Closing this alternative PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
This PR removes the remaining pre-v0.9 runtime vestiges after the backend cleanup in the preceding stack PRs. It drops obsolete shared network fields, the built-in test proxy, retired CLI testing switches, and the unused Unix proxy coordinator while preserving supported directional and caller-managed proxy behavior. It also redacts non-string proxy diagnostics and clarifies accepted WSLC network postures.
Details
🔗 References
Depends on #1424; the stack begins at #1421. #1397 is the single-commit alternative to these five PRs; merge either the stack or the combined PR, not both. Follows #1382 and #1383.
🔍 Validation
Tests
src/,cargo fmt --all -- --check: passed.cargo check --workspace --all-targets --all-features --quiet: passed.cargo clippy --workspace --all-targets --all-features --quiet -- -D warnings: passed.cargo test --workspace --quiet: passed.cargo test -p mxc-sdk --lib --features wslc,isolation_session,microvm,hyperlight --quiet: 3,293 passed, 3 ignored.cargo test -p mxc-sdk --lib non_string_proxy_values_in_comments_are_redacted --quiet: 1 passed on Windows.cargo check -p mxc-sdk --all-targets --target x86_64-apple-darwin --quiet: passed.src/,cargo check -p mxc-sdk --all-targets --quiet: passed.cargo test -p mxc-sdk --lib lxc::common --quiet -- --test-threads=1: 302 passed.cargo test -p mxc-sdk --lib bubblewrap::common --quiet -- --test-threads=1: 301 passed.cargo build -p lxc -p unix_test_proxy --quiet: passed;bash ../tests/scripts/run_bwrap_directional_test.sh: nine checks passed.node --test scripts/versioning/tests/check-contract-codegen.test.js: 9 passed;node scripts/versioning/check-contract-codegen.js --check: passed, three artifact sets matched.✅ Checklist
Cargo.lock, thedependency-feed-checkcheck passes (see docs/pull-requests.md)📋 Issue Type
GitHub Actions runs the PR validation build automatically. The ADO pipeline
(
MXC-PR-Build) is the Azure version of the PR pipeline, kept in parity with the GitHubActions build; it runs on merge to
main, and Microsoft reviewers with write access can trigger iton a PR with
/azp run. See docs/pull-requests.md.If the
dependency-feed-checkcheck fails on a new dependency, the crate must be added tothe feed before the PR can pass. See docs/pull-requests.md
for the steps.
Microsoft Reviewers: Open in CodeFlow