Skip to content

Remove remaining pre-v0.9 runtime vestiges - #1426

Closed
Gudge (MGudgin) wants to merge 1 commit into
user/gudge/retire-network-unixfrom
user/gudge/retire-network-final-slice
Closed

Gudge (MGudgin) wants to merge 1 commit into
user/gudge/retire-network-unixfrom
user/gudge/retire-network-final-slice

Conversation

@MGudgin

@MGudgin Gudge (MGudgin) commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

📖 Description

This PR removes the remaining pre-v0.9 runtime vestiges after the backend cleanup in the preceding stack PRs. It drops obsolete shared network fields, the built-in test proxy, retired CLI testing switches, and the unused Unix proxy coordinator while preserving supported directional and caller-managed proxy behavior. It also redacts non-string proxy diagnostics and clarifies accepted WSLC network postures.

Details

  • Remove unrepresentable shared runtime fields and obsolete testing plumbing.
  • Simplify ProcessContainer audit and proxy ownership without weakening enforcement.
  • Update schema, telemetry, and backend guidance for supported requests.
  • Redact non-string proxy diagnostics and clarify supported networking guidance.

🔗 References

Depends on #1424; the stack begins at #1421. #1397 is the single-commit alternative to these five PRs; merge either the stack or the combined PR, not both. Follows #1382 and #1383.

🔍 Validation

Tests

  • From src/, cargo fmt --all -- --check: passed.
  • cargo check --workspace --all-targets --all-features --quiet: passed.
  • cargo clippy --workspace --all-targets --all-features --quiet -- -D warnings: passed.
  • cargo test --workspace --quiet: passed.
  • cargo test -p mxc-sdk --lib --features wslc,isolation_session,microvm,hyperlight --quiet: 3,293 passed, 3 ignored.
  • cargo test -p mxc-sdk --lib non_string_proxy_values_in_comments_are_redacted --quiet: 1 passed on Windows.
  • cargo check -p mxc-sdk --all-targets --target x86_64-apple-darwin --quiet: passed.
  • Debian WSL, from src/, cargo check -p mxc-sdk --all-targets --quiet: passed.
  • Debian WSL, cargo test -p mxc-sdk --lib lxc::common --quiet -- --test-threads=1: 302 passed.
  • Debian WSL, cargo test -p mxc-sdk --lib bubblewrap::common --quiet -- --test-threads=1: 301 passed.
  • Debian WSL, cargo build -p lxc -p unix_test_proxy --quiet: passed; bash ../tests/scripts/run_bwrap_directional_test.sh: nine checks passed.
  • node --test scripts/versioning/tests/check-contract-codegen.test.js: 9 passed; node scripts/versioning/check-contract-codegen.js --check: passed, three artifact sets matched.
  • Node/.NET SDK suites and native macOS/LXC runtime tests were not run locally.

✅ Checklist

📋 Issue Type

  • Bug fix
  • Feature
  • Task

GitHub Actions runs the PR validation build automatically. The ADO pipeline
(MXC-PR-Build) is the Azure version of the PR pipeline, kept in parity with the GitHub
Actions build; it runs on merge to main, and Microsoft reviewers with write access can trigger it
on a PR with /azp run. See docs/pull-requests.md.

If the dependency-feed-check check fails on a new dependency, the crate must be added to
the feed before the PR can pass. See docs/pull-requests.md
for the steps.

Microsoft Reviewers: Open in CodeFlow

@MGudgin
Gudge (MGudgin) requested a review from a team as a code owner October 6, 2026 21:25
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

This PR removes the remaining obsolete runtime network fields and built-in
test proxy after the backends adopt supported directional policy. It keeps
caller-managed proxy behavior and fails closed on unsafe diagnostics.

Details

* Remove shared fields, ownerless Unix coordinator and retired CLI flag.
* Simplify ProcessContainer ownership and preserve network audits.
* Redact non-string proxy diagnostics and correct WSLc guidance.

Tests

* Rust format, all-feature check, strict Clippy and workspace tests passed.
* Feature suite: 3293 passed, 3 ignored; redaction regression passed.
* Linux LXC/Bubblewrap: 603 passed; directional host suite passed.
* macOS target check and schema codegen passed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 7570a662-a429-46d2-aa24-47fae6655cc4
Generated-with: gpt-6-sol
@MGudgin
Gudge (MGudgin) force-pushed the user/gudge/retire-network-final-slice branch from bd0f149 to b551af1 Compare October 6, 2026 21:57
@MGudgin

Copy link
Copy Markdown
Member Author

Superseded by merged #1397, which includes the final shared-model and proxy cleanup in this stacked PR. Closing this alternative PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant