You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Enhance NVX integration documentation with detailed updates on state-aware process lifetime, discovery payloads, lifecycle management, SDK behavior, filesystem access, and network rules.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Preserve Linux NanVix routing while limiting NVX to Windows x64
docs/nvx-integration.md:22
The unconditional replacement drops an existing platform path: mxc_engine currently routes microvm to NanVix on Linux as well as Windows (src/core/mxc_engine/src/run.rs:294-307,349-370), and the Linux runner uses KVM. Since section 7 limits the initial NVX integration to Windows x64, define whether Linux keeps NanVix until NVX support arrives (and retain Linux coverage) rather than silently making microvm unavailable there.
Select and validate linux/amd64 OCI manifests deterministically
docs/nvx-integration.md:798
Digest resolution alone does not define which manifest to choose from a multi-platform OCI index. The host is Windows x64 but the guest is Linux, so host-platform selection can choose an unusable windows/amd64 image; ARM-only and Windows-only references also need a deterministic rejection. Make linux/amd64 selection and platform validation part of the conversion contract.
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
The reason will be displayed to describe this comment to others. Learn more.
Why these restrictions around volume and shared common directory? Why can't I map file paths on both c:\ and d:? Why can't I map c:\etc\src\git\myrepo and c:\users\gudge\mydocs ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Documents the proposed NVX integration in MXC.
✅ Checklist
Cargo.lock, thedependency-feed-checkcheck passes (see docs/pull-requests.md)📋 Issue Type
Microsoft Reviewers: Open in CodeFlow