Repository navigation
Update the Learning Mode network provider GUID - #1509
Merged
Richie Gomez (richiemsft) merged 2 commits intoOct 15, 2026
Merged
Richie Gomez (richiemsft) merged 2 commits into
Richie Gomez (richiemsft) merged 2 commits into
Conversation
Recognize the OS-manifested Learning Mode network provider alongside the earlier identity, preserve the observed GUID in verbose diagnostics, and cover both identities with regression tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16300264-31dd-4214-a056-f01395e3179e
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes preserve existing validation and capture behavior, with regression coverage and no identified blocking issues.
0 open findings
What changed in this PR
Fixes missing network denials in ProcessContainer capture by recognizing the manifested provider GUID alongside the earlier identity.
Changes:
- Shares provider recognition across routing, extraction, classification, and decode-error handling.
- Preserves the observed GUID in verbose signatures.
- Adds regression coverage and updates documentation without changing schemas or network policy.
| File | Description |
|---|---|
src/mxc-sdk/src/core/learning_mode_windows/network_extractors.rs |
Defines shared recognition for both provider identities. |
src/mxc-sdk/src/core/learning_mode_windows/extractors.rs |
Applies recognition to classification and process scoping. |
src/mxc-sdk/src/core/learning_mode_windows/etl_decode.rs |
Updates routing, preserves observed GUIDs, and adds regression coverage. |
docs/logging-access-denied.md |
Documents both identities and updates the verbose example. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Replace obsolete GUID values in routing, extraction, output, existing fixtures and documentation. Remove the compatibility implementation so the PR contains only GUID-value replacements. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16300264-31dd-4214-a056-f01395e3179e
Gudge (MGudgin)
approved these changes
Oct 15, 2026
Richie Gomez (richiemsft)
deleted the
richiemsft/fix-network-capture-provider-guid
branch
October 15, 2026 21:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix missing network denials in native
processContainer.captureDenialsoutput.The managed Learning Mode ETL already contains
Microsoft-Windows-LearningMode-NetworkDecisionevents under the provider GUID{301EC03D-2951-5EFB-6D99-59C64628BBFC}. MXC used the obsolete GUID, so it discarded those records as unrelated provider traffic before decoding their payloads. This left both actionable network denials and verbose network signatures empty despite real WFP policy drops.Replace the old GUID with the current GUID everywhere it is duplicated: event routing, extraction, verbose output, telemetry projection, existing test fixtures/assertions, and documentation.
The entire PR is 16 GUID-value line replacements across seven existing files. There are no added helpers, compatibility aliases, fallback paths, new tests, or other logic changes. The old provider is no longer recognized.
No schema, dependency, or network-policy changes.
References
Validation
Automated checks from
src:cargo fmt --all -- --checkcargo test -p mxc-sdk --lib learning_mode --quiet- 332 passed, 1 manual benchmark ignored.cargo test -p mxc-sdk --lib capture_output --quiet- 21 passed.cargo test -p mxc-sdk --lib verbose_telemetry --quiet- 10 passed.cargo clippy -p mxc-sdk --lib --tests --quiet -- -D warningscargo build --release --target x86_64-pc-windows-msvc -p wxc -p mxc_ffi --quietManual verification on an x64 Windows 26711.1000 VM using rebuilt release executables and the public .NET V1 SDK:
203.0.113.10:443, UDP203.0.113.10:53, and TCP198.51.100.20:8443.Checklist
Cargo.lock, thedependency-feed-checkcheck passes (not applicable; unchanged)Issue Type