Repository navigation
[WSLC] Generate session names when containerId is omitted - #1514
Merged
Soham Das (SohamDas2021) merged 1 commit intoOct 16, 2026
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The scoped fix preserves explicit IDs, includes regression coverage, and has no identified blocking issues.
0 open findings
What changed in this PR
Fixes #1484 by generating unique WSLC session names when create-and-run requests omit or empty containerId, while preserving explicit IDs.
Changes:
- Generates
mxc-wslc-<uuid>names and logs the resolved name. - Adds unit and integration regression coverage.
- Documents optional IDs and backend-defined naming.
| File | Description |
|---|---|
| tests/scripts/run_wslc_all_tests.ps1 | Runs the omitted-ID regression case. |
| tests/configs/wslc_no_container_id.json | Adds a WSLC request without an ID. |
| src/tools/wxc/src/main.rs | Clarifies logging for unnamed requests. |
| src/mxc-sdk/src/backends/wslc/common/wsl_container_runner.rs | Generates session names and adds unit tests. |
| docs/schema.md | Documents optional container IDs. |
| docs/backends/wslc/wsl-container-getting-started.md | Explains WSLC session naming. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Branden Bonaby (bbonaby)
approved these changes
Oct 16, 2026
Soham Das (SohamDas2021)
deleted the
sohamdas2021-wslc-default-session-name
branch
October 16, 2026 18:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Generate a unique
mxc-wslc-<uuid>session name when a create-and-run WSLC request omits or emptiescontainerId, avoidingWSLC_E_INVALID_SESSION_NAME. Explicit IDs remain unchanged; regression coverage and documentation are included.🔗 References
Resolves #1484
🔍 Validation
cargo fmt --all -- --check— passedcargo clippy -p mxc-sdk -p wxc --features wslc --all-targets -- -D warnings— passedcargo test -p mxc-sdk --features wslc --lib— 3168 passed, 7 ignoredcargo test -p wxc— 70 passednode scripts/versioning/validate-configs.js— 410 configs validatedcargo build -p wxc --bin wxc-exec --features wslcandtarget\debug\wxc-exec.exe --debug ..\tests\configs\wslc_no_container_id.json— passed withNO_CONTAINER_ID_OK, exit 0✅ Checklist
Cargo.lock, thedependency-feed-checkcheck passes (see pull request builds)📋 Issue Type
GitHub Actions runs the PR validation build automatically. The ADO pipeline
(
MXC-PR-Build) is the Azure version of the PR pipeline, kept in parity with the GitHubActions build; it runs on merge to
main, and Microsoft reviewers with write access can trigger iton a PR with
/azp run. See pull request builds.If the
dependency-feed-checkcheck fails on a new dependency, the crate must be added tothe feed before the PR can pass. See pull request builds
for the steps.
Microsoft Reviewers: Open in CodeFlow