Skip to content

[WSLC] Generate session names when containerId is omitted - #1514

Merged
Soham Das (SohamDas2021) merged 1 commit into
mainfrom
sohamdas2021-wslc-default-session-name
Oct 16, 2026
Merged

Soham Das (SohamDas2021) merged 1 commit into
mainfrom
sohamdas2021-wslc-default-session-name

Conversation

@SohamDas2021

@SohamDas2021 Soham Das (SohamDas2021) commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

📖 Description

Generate a unique mxc-wslc-<uuid> session name when a create-and-run WSLC request omits or empties containerId, avoiding WSLC_E_INVALID_SESSION_NAME. Explicit IDs remain unchanged; regression coverage and documentation are included.

🔗 References

Resolves #1484

🔍 Validation

  • cargo fmt --all -- --check — passed
  • cargo clippy -p mxc-sdk -p wxc --features wslc --all-targets -- -D warnings — passed
  • cargo test -p mxc-sdk --features wslc --lib — 3168 passed, 7 ignored
  • cargo test -p wxc — 70 passed
  • node scripts/versioning/validate-configs.js — 410 configs validated
  • cargo build -p wxc --bin wxc-exec --features wslc and target\debug\wxc-exec.exe --debug ..\tests\configs\wslc_no_container_id.json — passed with NO_CONTAINER_ID_OK, exit 0

✅ Checklist

📋 Issue Type

  • Bug fix
  • Feature
  • Task

GitHub Actions runs the PR validation build automatically. The ADO pipeline
(MXC-PR-Build) is the Azure version of the PR pipeline, kept in parity with the GitHub
Actions build; it runs on merge to main, and Microsoft reviewers with write access can trigger it
on a PR with /azp run. See pull request builds.

If the dependency-feed-check check fails on a new dependency, the crate must be added to
the feed before the PR can pass. See pull request builds
for the steps.

Microsoft Reviewers: Open in CodeFlow

@SohamDas2021
Soham Das (SohamDas2021) requested a review from a team as a code owner October 16, 2026 02:48
Copilot AI balanced review requested due to automatic review settings October 16, 2026 02:48
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The scoped fix preserves explicit IDs, includes regression coverage, and has no identified blocking issues.

0 open findings

What changed in this PR

Fixes #1484 by generating unique WSLC session names when create-and-run requests omit or empty containerId, while preserving explicit IDs.

Changes:

  • Generates mxc-wslc-<uuid> names and logs the resolved name.
  • Adds unit and integration regression coverage.
  • Documents optional IDs and backend-defined naming.
File Description
tests/​scripts/​run_wslc_all_tests.ps1 Runs the omitted-ID regression case.
tests/​configs/​wslc_no_container_id.json Adds a WSLC request without an ID.
src/​tools/​wxc/​src/​main.rs Clarifies logging for unnamed requests.
src/​mxc-sdk/​src/​backends/​wslc/​common/​wsl_container_runner.rs Generates session names and adds unit tests.
docs/​schema.md Documents optional container IDs.
docs/​backends/​wslc/​wsl-container-getting-started.md Explains WSLC session naming.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@SohamDas2021
Soham Das (SohamDas2021) merged commit 0658689 into main Oct 16, 2026
31 checks passed
@SohamDas2021
Soham Das (SohamDas2021) deleted the sohamdas2021-wslc-default-session-name branch October 16, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[WSLC] One-shot without containerId fails: default session name "CLI" refused (WSLC_E_INVALID_SESSION_NAME, 0x80040608)

3 participants