Repository navigation
Add captureDenials to the .NET SDK - #938
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f9ac49b1-fdfe-4cca-9412-9faa99cef2ab
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f9ac49b1-fdfe-4cca-9412-9faa99cef2ab
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f9ac49b1-fdfe-4cca-9412-9faa99cef2ab
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds .NET SDK configuration, documentation, tests, and sample usage for Windows denial capture.
Changes:
- Adds block/allow capture policy serialization.
- Documents capture outputs, warnings, and ETL cleanup.
- Demonstrates and tests run and streaming metadata.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
sdk/dotnet/README.md |
Documents denial capture usage and cleanup. |
Microsoft.Mxc.Sdk/SandboxPolicy.cs |
Adds denial-capture policy types. |
Microsoft.Mxc.Sdk/SandboxOutputMetadata.cs |
Clarifies retained ETL cleanup. |
Microsoft.Mxc.Sdk/MxcSandbox.cs |
Centralizes policy serialization. |
Microsoft.Mxc.Sdk.Tests/MxcSandboxTests.cs |
Tests capture policy serialization. |
Microsoft.Mxc.Sdk.Sample/Program.cs |
Demonstrates capture and metadata reporting. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Branden Bonaby (bbonaby)
approved these changes
Aug 19, 2026
| Assert.True(capture.GetProperty("retainEtl").GetBoolean()); | ||
| } | ||
|
|
||
| [Fact] |
Collaborator
There was a problem hiding this comment.
note: didn't realize we hadn't done this yet but we probably want to hook these tests up to the PR pipelines in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Adds
captureDenialspolicy configuration to the .NET SDK, including block/allow modes, optional output paths, and retained ETL configuration. The sample now demonstrates opt-in denial capture and reports capture metadata for run-to-completion and streaming execution.The documentation covers sensitive ETL cleanup and notes that streaming processes do not currently expose security warnings; callers that use allow mode and need warning inspection should use
RunorRunAsync.🔗 References
main.🔍 Validation
dotnet test sdk\dotnet\Microsoft.Mxc.Sdk.slnx— 39 passednode scripts\check-dotnet-bindings-codegen.jsnode scripts\check-dotnet-errorcode-parity.jsgit diff --check✅ Checklist
Cargo.lock, thedependency-feed-checkcheck passes (see docs/pull-requests.md)📋 Issue Type
Microsoft Reviewers: Open in CodeFlow