Add 0.8 state-aware configuration adapters by MGudgin · Pull Request #941 · microsoft/mxc

Gudge (MGudgin) · 2026-08-18T23:58:21Z

This PR adds exhaustive state-aware adapters for the mutable 0.8.0-alpha configuration contract.

This PR is stacked on #929.

Details

Map every state-aware lifecycle and provision request into the current wire model.
Preserve validated experimental data and source text in a neutral pre-normalization value.
Destructure contract marker fields by their qualified type pattern rather than discarding them, so widening a marker fails to compile at the adapters that hardcode its wire value.
Add development-request facade coverage plus comprehensive expected-wire and current-wire equivalence tests.

Tests

cargo fmt --all -- --check
cargo check --workspace --all-targets
cargo clippy -p wxc_common -p mxc_config_contract --all-targets -- -D warnings
cargo test -p wxc_common -p mxc_config_contract

Microsoft Reviewers: Open in CodeFlow

azure-pipelines · 2026-08-18T23:58:30Z

Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run.

This PR updates the version-specific parser plan with the completed Phase 5D adapter boundary and Phase 7 integration responsibilities. Details * Record Phase 5D completion and PR #941. * Document the development adapter facade and neutral state-aware wire input. * Keep final-model convergence, shared normalization, and diagnostic parity in Phase 7. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1ef43cc5-5752-426e-a36e-eb9aaccfb9ad

Copilot

Pull request overview

Adds exhaustive adapters from the 0.8.0-alpha state-aware contracts into the existing wire model.

Changes:

Adds adapters for all lifecycle phases and provision backends.
Preserves raw experimental configuration and source text.
Adds comprehensive mapping and wire-equivalence tests.

Show a summary per file

File	Description
`src/core/wxc_common/src/state_aware_wire.rs`	Defines the pre-normalization state-aware representation.
`src/core/wxc_common/src/lib.rs`	Registers the new wire module.
`src/core/wxc_common/src/config_contract_adapters/mod.rs`	Updates adapter staging comments.
`src/core/wxc_common/src/config_contract_adapters/dev/common.rs`	Centralizes shared conversions.
`src/core/wxc_common/src/config_contract_adapters/dev/mod.rs`	Adds the unified development-request adapter.
`src/core/wxc_common/src/config_contract_adapters/dev/one_shot.rs`	Reuses shared conversion helpers.
`src/core/wxc_common/src/config_contract_adapters/dev/state_aware.rs`	Implements state-aware request conversions.
`src/core/wxc_common/src/config_contract_adapters/dev/state_aware_tests/mod.rs`	Registers state-aware test modules.
`src/core/wxc_common/src/config_contract_adapters/dev/state_aware_tests/common.rs`	Tests raw data and source preservation.
`src/core/wxc_common/src/config_contract_adapters/dev/state_aware_tests/provision.rs`	Tests all provision adapters.
`src/core/wxc_common/src/config_contract_adapters/dev/state_aware_tests/start.rs`	Tests start adaptation.
`src/core/wxc_common/src/config_contract_adapters/dev/state_aware_tests/exec.rs`	Tests exec adaptation.
`src/core/wxc_common/src/config_contract_adapters/dev/state_aware_tests/stop.rs`	Tests stop adaptation.
`src/core/wxc_common/src/config_contract_adapters/dev/state_aware_tests/deprovision.rs`	Tests deprovision adaptation.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Files reviewed: 14/14 changed files
Comments generated: 0
Review effort level: Balanced

Copilot

Review details

Files reviewed: 14/14 changed files
Comments generated: 0 new
Review effort level: Balanced

This PR adds the Phase 5A review follow-up to the plan's stack record and repoints Phase 6 at the new top of the stack. Details * Record PR #949 as part of stack #948 and note that #909 has merged. * Base Phase 6 on #949 rather than #941, since #949 rewrites the `string_enum!` macros and enum declarations that Phase 6.1 and 6.2 edit. * Point Phase 6.2's schema emission at the post-#949 macro, which already derives test coverage from the same value table. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6126ba9a-a004-486c-86b9-03d9e06db54b

Copilot

Review details

Files reviewed: 14/14 changed files
Comments generated: 0 new
Review effort level: Balanced

This PR adds exhaustive state-aware adapters for the mutable 0.8.0-alpha configuration contract. Details * Map every state-aware lifecycle and provision request into the current wire model. * Preserve validated experimental data and source text in a neutral pre-normalization value. * Destructure contract marker fields by their qualified type pattern rather than discarding them, so widening a marker fails to compile at the adapters that hardcode its wire value. * Add development-request facade coverage plus comprehensive expected-wire and current-wire equivalence tests. Tests * `cargo fmt --all -- --check` * `cargo check -p wxc_common` * `cargo clippy -p wxc_common --all-targets -- -D warnings` * `cargo test -p wxc_common` Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1ef43cc5-5752-426e-a36e-eb9aaccfb9ad

This PR updates the version-specific parser plan to match the current state of the work: Phase 5 is merged end to end, and the capabilities parity finding is being remediated in the Phase 5 stack rather than on the Phase 6 branch. Details * Mark Phases 5B, 5C, and 5D merged in PRs #910, #929, and #941, and record #949 as retargeted onto main now that the stack beneath it has landed. * Add PR #966 to the Phase 5 status list as the capabilities remediation, and repoint the two "top of the Phase 5 stack" references at it. * Resolve remediation item 2 of the Phase 6 review finding: the ProcessContainerCapability newtype landed, the parse-time versus conversion-time asymmetry is now the accepted state, and the shared-constant and parity-test drift risk is recorded as still open. * Note that the unpushed Phase 6 branch carries a duplicate capabilities commit that must be dropped when it rebases onto the merged stack. Tests * Documentation-only change; no build, lint, or test gate applies. * git diff --check passes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2a8e0d88-21dd-48e5-8e44-df2393b8a664