Repository navigation
Require a positive LocalAgentUser feature level for isolation_session - #960
Merged
Merged
Conversation
Class registration alone was reported as availability, so a host that registers the WinRT class but does not support the capability the lifecycle needs was advertised as able to run isolation sessions. Query the feature level and treat anything but a positive value, including a failed query, as unavailable. The test-script README, the suite comments and the skip messages each enumerated the causes behind a false read of the probe field. Drop the enumerations rather than extend them: the text around them is about how the suites skip, not why. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates IsolationSession availability detection to require the lifecycle’s LocalAgentUser capability.
Changes:
- Queries
GetFeatureLevel(LocalAgentUser)and fails closed. - Adds positive, zero, negative, and error-result tests.
- Simplifies test skip messaging.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/backends/isolation_session/common/src/availability.rs |
Strengthens availability probing. |
tests/scripts/run_isolation_session_tests.ps1 |
Simplifies skip details. |
tests/scripts/run_isolation_session_state_aware_tests.ps1 |
Simplifies prerequisite and skip text. |
tests/scripts/run_isolation_session_resize_smoke.ps1 |
Simplifies skip text. |
tests/scripts/README.md |
Generalizes skip documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Jeffrey Stall (jeffstall)
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
The probe reported a host as available whenever
IsoSessionOpsactivated, but activation also succeeds where the capability the lifecycle needs is unsupported. It now requiresGetFeatureLevel(LocalAgentUser)above zero as well, and treats a failed query as unavailable — failing closed, as the WSLc probe does.Nothing on the execution path consults this probe, so running a sandbox is unaffected;
--probeandplatform_supportare what move. The docs and skip messages around it enumerated the causes behind a false read; those enumerations are dropped rather than extended.🔍 Validation
cargo fmt --check,cargo clippy -p isolation_session_common --all-targets -- -D warningsandcargo test -p isolation_session_common --releaseare green.On a VM with the OS-side service, this build and a baseline from the merge base were run against the same host in both capability states:
truetruetruefalseThe baseline column is the control: it shows the previous probe advertising a host that cannot run isolation sessions, and confirms the difference comes from the new check rather than from activation failing.
✅ Checklist
📋 Issue Type
Microsoft Reviewers: Open in CodeFlow