Skip to content

Conversation

@wptestyyh
Copy link
Member

Type

  • Bug fix
  • Feature addition
  • [] Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

This change fixes below issues that is found when testing against AFW83 attenuator.

  • select first parameter is not optional on Linux, it must be the socket descriptor+1
  • select will change the timeout parameter, so it cannot be reused and must be reinitialized
  • CLI single dash switch (-) can only be followed by a single character

Technical Details

  • None

Test Results

  • Test it works with AFW83
    ./rfattenuator-cli socket "AFW83" 192.168.3.137 10001
    Sanity check succeeded

Reviewer Focus

  • None

Future Work

  • Stablization

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@wptestyyh wptestyyh requested a review from a team as a code owner May 1, 2025 18:24
@wptestyyh wptestyyh merged commit 332c6f8 into develop May 2, 2025
5 checks passed
@wptestyyh wptestyyh deleted the bugfix branch May 2, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants