Skip to content

Conversation

@wptestyyh
Copy link
Member

@wptestyyh wptestyyh commented Oct 22, 2025

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Documentation
  • Build Infrastructure

Side Effects

  • Breaking change
  • Non-functional change

Goals

std::thread::joinable() is not the same as running. The thread can be joinable but already finished. The second call will be failed always if we use joinable to check if the thread is running.

Technical Details

  • Create flag m_timedEnableRunning and m_timedDisableRunning to check if the thread has finished
  • Add new test Succeeds when a timed enable operation is finished and Succeeds when a timed disable operation is finished

Test Results

  • /netremote-test-unit "WifiAccessPointTimedEnable API"
    ===============================================================================
    All tests passed (38 assertions in 1 test case)
    ./netremote-test-unit "WifiAccessPointTimedDisable API"
    ===============================================================================
    All tests passed (40 assertions in 1 test case)

Reviewer Focus

None

Future Work

Publish the fix in 0.5.3

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@wptestyyh wptestyyh requested a review from a team as a code owner October 22, 2025 18:00
@wptestyyh wptestyyh changed the title 0.5.3 release Fix the wrong check of running thread Oct 22, 2025
@wptestyyh wptestyyh requested a review from a team October 22, 2025 18:04
@wptestyyh wptestyyh merged commit 4cdde0c into develop Nov 4, 2025
1 of 4 checks passed
@wptestyyh wptestyyh deleted the runningthread branch November 4, 2025 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants