Add missing auth_settings_validation_error lang string - #3431
Merged
Merged
Conversation
auth_oidc_validate_auth_settings() in lib.php (added in a13728f, 'Re-organise
configuration pages for auth_oidc and local_o365...') calls
get_string('auth_settings_validation_error', 'auth_oidc') to build the
notification shown when settings validation fails, but the corresponding
lang string was never added.
Cherry-picked from microsoft/moodle-auth_oidc#70
(2c8b686ece4dba3a5a4a9ea47e5382c25291a54c)
There was a problem hiding this comment.
Pull request overview
This PR aims to add the missing auth_settings_validation_error language string for the auth_oidc plugin so the notification built by auth_oidc_validate_auth_settings() can display a localized heading when settings validation fails.
Changes:
- Adds an English (
en) lang string forauth_settings_validation_errorinauth_oidc.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Two commits independently added the same string keys without detecting the existing definitions, leaving two definitions each for error_masked_secret_not_changed and auth_settings_validation_error: - bcd2239 (Implement Azure portal style secret / certificate passphrase protection) added error_masked_secret_not_changed with wording that predates the "Change" checkbox UX. - 1cf6fb9 (Re-organise configuration pages for auth_oidc and local_o365...) re-added error_masked_secret_not_changed with updated wording matching the current checkbox-based UX, and also added auth_settings_validation_error - duplicating the fix applied in the previous commit on this branch (cherry-picked from microsoft/moodle-auth_oidc#70), which wasn't actually needed here since 1cf6fb9 already carried it with different wording. Keep the newer/current definitions (the ones matching the "Change" checkbox UX) and drop the stale/redundant ones. Also removes a pre-existing upstream duplicate, errorauthdisconnectinvalidmethod (added twice, identically, in 6f8e952 back in 2015). Harmless since both copies had the same value, but redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
auth_oidc_validate_auth_settings() in lib.php (added in a13728f, 'Re-organise configuration pages for auth_oidc and local_o365...') calls get_string('auth_settings_validation_error', 'auth_oidc') to build the notification shown when settings validation fails, but the corresponding lang string was never added.
Cherry-picked from microsoft/moodle-auth_oidc#70
(2c8b686ece4dba3a5a4a9ea47e5382c25291a54c)