Add missing auth_settings_validation_error lang string - #3433
Merged
Merged
Conversation
auth_oidc_validate_auth_settings() in lib.php (added in a13728f, 'Re-organise
configuration pages for auth_oidc and local_o365...') calls
get_string('auth_settings_validation_error', 'auth_oidc') to build the
notification shown when settings validation fails, but the corresponding
lang string was never added.
Cherry-picked from microsoft/moodle-auth_oidc#70
(2c8b686ece4dba3a5a4a9ea47e5382c25291a54c)
There was a problem hiding this comment.
Pull request overview
Adds the missing English language string used by auth_oidc_validate_auth_settings() when building the admin notification shown on invalid/contradictory OpenID Connect configuration, preventing a missing-string placeholder from being displayed.
Changes:
- Add
auth_settings_validation_errortoauth_oidcEnglish language pack to match existingget_string()usage.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Bring in line with wip-136768-m405: drop the auth_settings_validation_error added directly after auth_oidcdescription (from microsoft/moodle-auth_oidc#70) and the stale error_masked_secret_not_changed wording that predates the "Change" checkbox UX, replacing both with the current wording already used on m405, in the error-strings block after error_invalid_custom_claim. Also removes a pre-existing upstream duplicate, errorauthdisconnectinvalidmethod (added twice, identically, in 6f8e952 back in 2015). Harmless since both copies had the same value, but redundant.
cameron1729
reviewed
Sep 2, 2026
|
|
||
| $string['pluginname'] = 'OpenID Connect'; | ||
| $string['auth_oidcdescription'] = 'The OpenID Connect authentication plugin provides single-sign-on functionality using configurable IdP.'; | ||
| $string['auth_settings_validation_error'] = 'There are problems with the OpenID Connect settings:'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
auth_oidc_validate_auth_settings() in lib.php (added in a13728f, 'Re-organise configuration pages for auth_oidc and local_o365...') calls get_string('auth_settings_validation_error', 'auth_oidc') to build the notification shown when settings validation fails, but the corresponding lang string was never added.
Cherry-picked from microsoft/moodle-auth_oidc#70
(2c8b686ece4dba3a5a4a9ea47e5382c25291a54c)