Skip to content

theme_boost_o365teams: Remove dead core_course_renderer overrides - #3775

Open
Lai Wei (weilai-irl) wants to merge 1 commit into
MOODLE_500_STABLEfrom
wip-140395-m500
Open

Lai Wei (weilai-irl) wants to merge 1 commit into
MOODLE_500_STABLEfrom
wip-140395-m500

Conversation

@weilai-irl

Copy link
Copy Markdown
Collaborator

course_section_cm() and course_section_cm_name_title() no longer exist in the Moodle core course renderer, so the overrides were never called.

course_section_cm() and course_section_cm_name_title() no longer exist in the Moodle core course renderer, so the overrides were never called.
Copilot AI balanced review requested due to automatic review settings October 9, 2026 14:05
@weilai-irl Lai Wei (weilai-irl) self-assigned this Oct 9, 2026
@weilai-irl Lai Wei (weilai-irl) added this to the 2026-04 milestone Oct 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

It is a clean, fully-verified removal of dead code with no remaining references to the deleted class or file anywhere in the repository.

0 open findings

What changed in this PR

This PR removes a dead core_course_renderer override from the theme_boost_o365teams theme. The overridden methods course_section_cm() and course_section_cm_name_title() no longer exist on Moodle core's core_course_renderer (course module rendering has moved to the core_courseformat\output classes in recent Moodle versions, and the theme requires Moodle 5.0 / 2025040800), so the override class was never invoked and only carried maintenance burden.

Changes:

  • Deletes theme/boost_o365teams/classes/core_course_renderer.php (the dead override class).
  • Removes the require_once for that file from theme/boost_o365teams/renderers.php.
File Description
theme/​boost_o365teams/​classes/​core_course_renderer.php Removes the dead renderer override class that is no longer called by core.
theme/​boost_o365teams/​renderers.php Drops the require_once include for the deleted renderer file.

I verified repo-wide that no remaining references to the class theme_boost_o365teams_core_course_renderer or the deleted file path exist, so the removal is complete and self-consistent. No issues to comment on within the changed regions.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants