Skip to content

theme_boost_o365teams: Remove dead core_course_renderer overrides - #3776

Open
Lai Wei (weilai-irl) wants to merge 1 commit into
MOODLE_501_STABLEfrom
wip-140395-m501
Open

Lai Wei (weilai-irl) wants to merge 1 commit into
MOODLE_501_STABLEfrom
wip-140395-m501

Conversation

@weilai-irl

Copy link
Copy Markdown
Collaborator

course_section_cm() and course_section_cm_name_title() no longer exist in the Moodle core course renderer, so the overrides were never called.

course_section_cm() and course_section_cm_name_title() no longer exist in the Moodle core course renderer, so the overrides were never called.
Copilot AI balanced review requested due to automatic review settings October 9, 2026 14:05
@weilai-irl Lai Wei (weilai-irl) self-assigned this Oct 9, 2026
@weilai-irl Lai Wei (weilai-irl) added this to the 2026-04 milestone Oct 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The removed overrides target core methods deleted in Moodle 4.3+ (theme requires 5.1), the deletion is clean, and no references to the class or file remain anywhere in the repository.

0 open findings

What changed in this PR

This PR removes dead core_course_renderer overrides from the theme_boost_o365teams theme. The overridden methods course_section_cm() and course_section_cm_name_title() were removed from Moodle's core_course_renderer starting in Moodle 4.3 (course-format output was refactored into core_courseformat\output classes/templates). Since this theme requires Moodle 5.1 ($plugin->requires = 2025100600), these subclass overrides could never be invoked, making the file obsolete.

Changes:

  • Deleted classes/core_course_renderer.php, which held the two never-called renderer overrides.
  • Removed the corresponding require_once for that file from renderers.php, leaving the still-valid mod_assign and mod_quiz renderer includes.
File Description
theme/​boost_o365teams/​renderers.php Drops the require_once for the obsolete core_course_renderer.php.
theme/​boost_o365teams/​classes/​core_course_renderer.php Deletes the dead renderer subclass whose overridden core methods no longer exist in Moodle 5.1.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants