Repository navigation
theme_boost_o365teams: Remove dead core_course_renderer overrides - #3777
Lai Wei (weilai-irl) wants to merge 1 commit into
Conversation
course_section_cm() and course_section_cm_name_title() no longer exist in the Moodle core course renderer, so the overrides were never called.
There was a problem hiding this comment.
🟡 Changes recommended
The renderer file is removed without the decimal version bump in version.php that this repo's plugins apply for code-change PRs, so caches/upgrade won't be triggered to reflect the removal.
0 open findings
What changed in this PR
This PR removes dead code from the theme_boost_o365teams theme. It deletes the theme_boost_o365teams_core_course_renderer class (which overrode course_section_cm() and course_section_cm_name_title()) and the corresponding require_once in renderers.php. Because recent Moodle core no longer calls these core_course_renderer methods, the overrides were never executed, so removing them has no functional impact. I confirmed there are no remaining references to the removed class, file, or methods anywhere in the repository, and the theme's renderer auto-discovery (theme_overridden_renderer_factory in config.php) will simply fall back to the core renderer.
Changes:
- Delete the unused
classes/core_course_renderer.phprenderer override file. - Remove the now-dangling
require_onceof that file fromrenderers.php.
| File | Description |
|---|---|
| theme/boost_o365teams/renderers.php | Removes the require_once for the deleted renderer so no dangling include remains. |
| theme/boost_o365teams/classes/core_course_renderer.php | Deletes the dead renderer override class that core no longer invokes. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
course_section_cm() and course_section_cm_name_title() no longer exist in the Moodle core course renderer, so the overrides were never called.