Skip to content

theme_boost_o365teams: Remove dead core_course_renderer overrides - #3777

Open
Lai Wei (weilai-irl) wants to merge 1 commit into
MOODLE_502_STABLEfrom
wip-140395-m502
Open

Lai Wei (weilai-irl) wants to merge 1 commit into
MOODLE_502_STABLEfrom
wip-140395-m502

Conversation

@weilai-irl

Copy link
Copy Markdown
Collaborator

course_section_cm() and course_section_cm_name_title() no longer exist in the Moodle core course renderer, so the overrides were never called.

course_section_cm() and course_section_cm_name_title() no longer exist in the Moodle core course renderer, so the overrides were never called.
Copilot AI balanced review requested due to automatic review settings October 9, 2026 14:05
@weilai-irl Lai Wei (weilai-irl) self-assigned this Oct 9, 2026
@weilai-irl Lai Wei (weilai-irl) added this to the 2026-04 milestone Oct 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The renderer file is removed without the decimal version bump in version.php that this repo's plugins apply for code-change PRs, so caches/upgrade won't be triggered to reflect the removal.

0 open findings

What changed in this PR

This PR removes dead code from the theme_boost_o365teams theme. It deletes the theme_boost_o365teams_core_course_renderer class (which overrode course_section_cm() and course_section_cm_name_title()) and the corresponding require_once in renderers.php. Because recent Moodle core no longer calls these core_course_renderer methods, the overrides were never executed, so removing them has no functional impact. I confirmed there are no remaining references to the removed class, file, or methods anywhere in the repository, and the theme's renderer auto-discovery (theme_overridden_renderer_factory in config.php) will simply fall back to the core renderer.

Changes:

  • Delete the unused classes/core_course_renderer.php renderer override file.
  • Remove the now-dangling require_once of that file from renderers.php.
File Description
theme/​boost_o365teams/​renderers.php Removes the require_once for the deleted renderer so no dangling include remains.
theme/​boost_o365teams/​classes/​core_course_renderer.php Deletes the dead renderer override class that core no longer invokes.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants