DO NOT MERGE: Repo: Update to Rust 1.93#2710
Open
smalis-msft wants to merge 1 commit intomicrosoft:mainfrom
Open
DO NOT MERGE: Repo: Update to Rust 1.93#2710smalis-msft wants to merge 1 commit intomicrosoft:mainfrom
smalis-msft wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s minimum Rust toolchain to 1.93 and aligns all CI and helper tooling to use that version so the codebase can start validating against the newer compiler.
Changes:
- Bump
workspace.package.rust-versionin the root andxsyncworkspaces from 1.91 to 1.93. - Update the
RUSTUP_TOOLCHAINconstant used by flowey/hvlite to1.93.0. - Update all Azure DevOps and GitHub Actions workflows that install Rust via rustup to use
1.93.0as the default toolchain.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
Cargo.toml |
Raises the workspace rust-version to 1.93 to require the newer compiler across the main workspace. |
xsync/Cargo.toml |
Raises the xsync workspace rust-version to 1.93 to match the main workspace. |
flowey/flowey_lib_hvlite/src/cfg_rustup_version.rs |
Updates the RUSTUP_TOOLCHAIN constant from 1.91.1 to 1.93.0 so flowey’s hvlite tooling invokes the new toolchain. |
ci-flowey/openvmm-pr.yaml |
Updates all Azure DevOps CI steps that install Rust to use --default-toolchain=1.93.0 instead of 1.91.1. |
.github/workflows/openvmm-pr.yaml |
Updates GitHub Actions PR workflow to install Rust 1.93.0 on Linux and Windows runners. |
.github/workflows/openvmm-pr-release.yaml |
Updates the PR release workflow to install Rust 1.93.0 on all supported platforms. |
.github/workflows/openvmm-docs-pr.yaml |
Updates the docs PR workflow to use Rust 1.93.0 for building documentation. |
.github/workflows/openvmm-docs-ci.yaml |
Updates the docs CI workflow to use Rust 1.93.0 on all runners. |
.github/workflows/openvmm-ci.yaml |
Updates the main CI workflow to install Rust 1.93.0 everywhere Rust is bootstrapped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can't merge this until the internal toolchain binary size issue is fixed, but let's see if anything breaks at least.