virtio: reject queue_size of zero#2782
Closed
benhillis wants to merge 1 commit intomicrosoft:mainfrom
Closed
Conversation
A queue_size of 0 causes division-by-zero panics in get_available_descriptor_index and set_used_descriptor, which both compute modulo queue_size. Reject it early in QueueCore::new.
Contributor
There was a problem hiding this comment.
Pull request overview
Rejects invalid virtio queue configurations where queue_size == 0, preventing division-by-zero panics in core ring index math. This fits into the virtio device infrastructure by hardening queue initialization against invalid guest-provided parameters.
Changes:
- Add a new
QueueError::InvalidQueueSizeerror variant. - Validate
QueueParams.size != 0early inQueueCore::newand return a structured error otherwise.
Comment on lines
+52
to
+54
| if params.size == 0 { | ||
| return Err(QueueError::InvalidQueueSize); | ||
| } |
There was a problem hiding this comment.
Add a unit test covering the new params.size == 0 validation path in QueueCore::new (expecting Err(QueueError::InvalidQueueSize)) to prevent regressions back to modulo-by-zero panics.
Member
Author
|
Included this fix in #2780 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A queue_size of 0 causes division-by-zero panics in get_available_descriptor_index and set_used_descriptor, which both compute modulo queue_size. Reject it early in QueueCore::new.