Skip to content

Conversation

@maheeraeron
Copy link
Contributor

Enhances the inspect_mut on the UefiDevice such that you can now provide a log level to reprocess the UEFI diagnostics buffer with more verbosity.

This works because the in-memory buffer for UEFI logs technically contains all logs up to the VERBOSE level.

By default we only project ERROR and WARN logs, but now we can get INFO and VERBOSE logs at runtime via inspect.

Copilot AI review requested due to automatic review settings February 11, 2026 23:08
@maheeraeron maheeraeron requested a review from a team as a code owner February 11, 2026 23:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the UEFI diagnostics inspection capability by allowing dynamic log level overrides at runtime. The UEFI diagnostics buffer contains all logs up to the VERBOSE level, but by default only ERROR and WARN logs are projected. This change enables users to reprocess the buffer with increased verbosity (INFO or VERBOSE) via the inspect interface without requiring a restart.

Changes:

  • Added log_level_override: Option<LogLevel> parameter to diagnostics processing methods
  • Enhanced inspect_mut handler to accept "default", "info", or "full" values for runtime log level control
  • Updated all existing call sites to pass None, preserving default behavior

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
vm/devices/firmware/firmware_uefi/src/service/diagnostics/mod.rs Added log_level_override parameter to both DiagnosticsServices::process_diagnostics and UefiDevice::process_diagnostics methods with documentation updates
vm/devices/firmware/firmware_uefi/src/lib.rs Enhanced inspect_mut handler to parse log level values ("default"/"info"/"full") and updated all call sites to pass None for the new parameter
vm/devices/firmware/firmware_uefi/fuzz/fuzz_diagnostics.rs Updated fuzz test to pass None for the new log_level_override parameter

@github-actions
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant