Skip to content

Removed capabilities compatability script#142

Merged
uve merged 3 commits into
microsoft:mainfrom
bobalive:fix-vulnerability
Jan 6, 2026
Merged

Removed capabilities compatability script#142
uve merged 3 commits into
microsoft:mainfrom
bobalive:fix-vulnerability

Conversation

@bobalive

@bobalive bobalive commented Jan 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: REDMOND\v-bdjalalov <boburtjalalov@gmail.com>
Signed-off-by: REDMOND\v-bdjalalov <boburtjalalov@gmail.com>
Copilot AI review requested due to automatic review settings January 6, 2026 13:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the GitHub Actions workflow and associated JavaScript validation script that enforced capabilities.json compatibility checks. The removed automation validated that changes to capabilities.json didn't introduce breaking changes and enforced Power BI custom visual requirements.

Key Changes:

  • Deleted .github/workflows/capabilities-compatibility.yml - GitHub Actions workflow that ran on pull requests to check capabilities.json modifications
  • Deleted .github/scripts/check-capabilities-compatibility.js - Node.js script that performed the actual validation logic

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/capabilities-compatibility.yml Removed the CI workflow that triggered capabilities validation on PR changes to capabilities.json
.github/scripts/check-capabilities-compatibility.js Removed the validation script that checked for breaking changes, required properties (dataRoles, dataViewMappings), and blocked WebAccess privileges
Comments suppressed due to low confidence (3)

.github/workflows/capabilities-compatibility.yml:1

  • This PR removes important capabilities.json validation that enforced Power BI custom visual requirements. The removed workflow validated:
  1. Required properties (dataRoles, dataViewMappings)
  2. Blocking forbidden WebAccess privileges
  3. Preventing breaking changes to existing capabilities

These validations align with the repository's coding guidelines (see .github/copilot-instructions.md section 1). If this validation logic is being moved to another location or replaced by a different mechanism, please document this in the PR description. If the validation is being removed entirely, this represents a regression in automated quality checks that could allow breaking changes to merge.
.github/scripts/check-capabilities-compatibility.js:1

  • This PR removes the capabilities validation script without providing a PR description explaining why this change is being made or where the validation is being moved (if anywhere). According to the repository's coding guidelines, non-trivial changes should include context in the PR description and potentially an update to CHANGELOG.md. Please add a description explaining the rationale for removing this validation mechanism.
    .github/workflows/capabilities-compatibility.yml:1
  • The PR title contains a spelling error: "compatability" should be "compatibility".

Signed-off-by: REDMOND\v-bdjalalov <boburtjalalov@gmail.com>
@uve uve merged commit 36ac42d into microsoft:main Jan 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants