feat(settings): make colorbrewer and custom gradient mutually exclusi…#247
Merged
Demonkratiy merged 2 commits intoJun 15, 2026
Merged
Conversation
…ve in the UI - colorbrewer takes precedence in initColors; gradient middle is custom-only - disable the 'Custom gradient colors' group while colorbrewer is enabled - remove dead resolveStartEndColors and unused imports - share the Visual_GradientMiddle key for the toggle and picker
There was a problem hiding this comment.
Pull request overview
This PR clarifies and enforces that Colorbrewer palettes and the custom gradient are mutually exclusive color sources in the TableHeatMap visual, making the active mode more obvious in the Format pane and ensuring gradient-middle is custom-gradient-only.
Changes:
- Make
initColorsalways prefer Colorbrewer when enabled, and treat gradient middle as a custom-gradient-only feature. - Disable the “Custom gradient colors” formatting group while Colorbrewer is enabled.
- Remove dead
resolveStartEndColorscode and update tests/strings/changelog accordingly.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/visualTest.ts | Replaces picker-sync test with coverage for Colorbrewer precedence, group disabling, and gradient-middle behavior. |
| stringResources/en-US/resources.resjson | Renames the gradient group label and removes the old toggle-specific resource key. |
| src/visual.ts | Removes picker-syncing and makes Colorbrewer take precedence over gradient-middle/custom gradient logic. |
| src/settings.ts | Shares the “Gradient middle” label key and disables the custom gradient group when Colorbrewer is enabled. |
| src/heatmapUtils.ts | Removes unused resolveStartEndColors helper and related imports. |
| pbiviz.json | Removes version text from the visual display name. |
| CHANGELOG.md | Updates release notes to reflect the UI/behavior changes around gradient middle and Colorbrewer vs custom gradient. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kullJul
approved these changes
Jun 15, 2026
kullJul
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ve in the UI
colorbrewer takes precedence in initColors; gradient middle is custom-only
disable the 'Custom gradient colors' group while colorbrewer is enabled
remove dead resolveStartEndColors and unused imports
share the Visual_GradientMiddle key for the toggle and picker