Add Level filter column to events list for Error/Warning/Resolved/Info filtering#986
Add Level filter column to events list for Error/Warning/Resolved/Info filtering#986
Conversation
Co-authored-by: sridmad <7445097+sridmad@users.noreply.github.com>
|
@copilot update the PR description such that the associated issue is resolved once merge is complete |
Updated the PR description to include "Fixes #928" at the top. When this PR is merged, it will automatically close issue #928. The updated PR description should now read: Fixes #928 During livesite incidents, critical events like Changes
Implementation// Events.ts - FabricEventInstanceModel
public get eventStatus(): string {
if (HtmlUtils.eventTypesUtil.isError(this.raw)) return 'Error';
if (HtmlUtils.eventTypesUtil.isWarning(this.raw)) return 'Warning';
if (HtmlUtils.eventTypesUtil.isResolved(this.raw)) return 'Resolved';
return 'Info';
}
// Collections.ts - EventListBase.createListSettings()
new ListColumnSetting('eventStatus', 'Status', {
enableFilter: true,
sortPropertyPaths: ['eventStatus']
})Users can now filter events by clicking the Status column filter icon and selecting/deselecting severity levels. Unchecking "Info" removes informational noise; selecting only "Error" shows critical events. 20 lines added across 2 files. Uses existing filter dropdown infrastructure. |
|
@copilot rename the column to "Level", and add cypress test to cluster.cy.js to verify event status gets displayed properly |
…isplay Co-authored-by: chensation <32966177+chensation@users.noreply.github.com>
Co-authored-by: chensation <32966177+chensation@users.noreply.github.com>
Renamed the column from "Status" to "Level" and added Cypress test in commit d119769. The test verifies:
Changes:
|
|
@copilot pull the latest from master branch to fix the flaky test. Then modify the new test to check that each case of Error, Warning, Info, and Resolved display the correct value for a given event of that level. |
…explorer into copilot/filter-events-by-error-warning
…ng/Resolved/Info) Co-authored-by: chensation <32966177+chensation@users.noreply.github.com>
Merged latest from master and enhanced the test in commit 189fa3c. The improved test now:
Changes:
|
During livesite incidents, critical events like
NodeDownwere obscured by informational noise (ClusterHealthReportExpired,ClusterNewHealthReport). Users needed to filter by severity.Changes
Added
eventStatuscomputed property toFabricEventInstanceModel"Error"|"Warning"|"Resolved"|"Info"HtmlUtils.eventTypesUtilclassification (isError/isWarning/isResolved)Added Level column to events list
Added Cypress test in
cluster.cy.jscluster-events-all-levels.jsonwith one event of each level (Error, Warning, Resolved, Info)Implementation
Users can now filter events by clicking the Level column filter icon and selecting/deselecting severity levels. Unchecking "Info" removes informational noise; selecting only "Error" shows critical events.
Testing
Adds Level column with 23 lines of code changes and comprehensive test fixture with 4 events covering all severity levels. Uses existing filter dropdown infrastructure.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.