Activity specific builders for outgoing activities#392
Open
MehakBindra wants to merge 1 commit intonext/corefrom
Open
Activity specific builders for outgoing activities#392MehakBindra wants to merge 1 commit intonext/corefrom
MehakBindra wants to merge 1 commit intonext/corefrom
Conversation
singhk97
reviewed
Mar 26, 2026
| /// <typeparam name="TBuilder">The concrete builder type (for fluent chaining).</typeparam> | ||
| public abstract class TeamsActivityBuilder<TActivity, TBuilder> : CoreActivityBuilder<TActivity, TBuilder> | ||
| where TActivity : TeamsActivity | ||
| where TBuilder : TeamsActivityBuilder<TActivity, TBuilder> |
Collaborator
There was a problem hiding this comment.
How does this recursive TBuilder definition work?
Member
There was a problem hiding this comment.
it's called CRTP pattern , or in our specific case Fluent builder inheritance or self-referential generics
it's a bit of a workaround for the lack of a Self type
if you are interested here it is a very related discussion dotnet/csharplang#7325
rido-min
reviewed
Mar 27, 2026
|
|
||
| MessageActivityBuilder result1 = msgBuilder.WithId("id"); | ||
| MessageActivityBuilder result2 = msgBuilder.WithText("text"); | ||
| MessageActivityBuilder result3 = msgBuilder.WithType(TeamsActivityType.Message); |
Member
There was a problem hiding this comment.
How can we hide WithType to avoid this usage?
var msg = MessageActivity.CreateBuilder()
.WithType("not-message")
.Build()Eg:
- Make CoreMessageBuilder.WithType virtual
- Override in MessageActivityBuilder and check the valid values for "type" to throw in the other cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed: Introduced type-specific activity builders alongside the existing TeamsActivityBuilder.
New types
Why
With dedicated builders, MessageActivity.CreateBuilder().WithText(...).Build() returns a MessageActivity — activity.Text just works. Same for SuggestedActions, TextFormat, etc.
Ripple changes