chore: remove dead *ActivityInput classes for inbound-only types#341
Closed
rajan-chari wants to merge 1 commit intofix/338-remove-unsendable-input-typesfrom
Closed
chore: remove dead *ActivityInput classes for inbound-only types#341rajan-chari wants to merge 1 commit intofix/338-remove-unsendable-input-typesfrom
rajan-chari wants to merge 1 commit intofix/338-remove-unsendable-input-typesfrom
Conversation
Delete 7 *ActivityInput classes that were removed from the ActivityParams union in the previous commit and have zero references: - MessageDeleteActivityInput - MessageUpdateActivityInput - ConversationUpdateActivityInput - HandoffActivityInput - TraceActivityInput - CommandSendActivityInput - CommandResultActivityInput These represented inbound-only event types (server→bot) and had no valid outbound send path. The corresponding *Activity classes (used as handler type hints) are preserved. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Mar 31, 2026
Contributor
Author
Manual Test Results — Echo Bot (Python)Tested on branch
All 5 test steps passed. Removing the dead |
Collaborator
|
added comment here #340 (comment) |
Collaborator
|
closing to handle all changes in #340 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #340. Deletes 7
*ActivityInputclasses that were removed from theActivityParamsunion and have zero references anywhere in the codebase.Deleted classes:
MessageDeleteActivityInputMessageUpdateActivityInputConversationUpdateActivityInputHandoffActivityInputTraceActivityInputCommandSendActivityInputCommandResultActivityInputThe corresponding
*Activityclasses (used as handler type hints for incoming events) are preserved.Why
These classes existed for model symmetry (every Activity type had an Input counterpart) but represented inbound-only event types. They had no valid outbound send path and no references outside their own definitions and
__init__.pyexports. Removing them eliminates the suggestion that these types are constructible for any purpose.Test plan
Automated
Verification
from microsoft_teams.api.activities import MessageDeleteActivityInputraisesImportErrorfrom microsoft_teams.api.activities import MessageDeleteActivitystill works@app.on_message_delete,@app.on_message_update, etc.) still work with incoming Activity types🤖 Generated with Claude Code