Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partially resolves: #338
old pr: #343 (abandoned, had to cherry pick due to removal of prev commits)
previously, the only way to delete an activity was directly calling
await app.api.conversations.activities(conversation_reference.conversation.id).delete(conversation_reference.activity_id)this wasn't very consistent with our flow for sending and updating activities (via
send). hence, we are now addingctx.delete(activity_id)toActivityContextfor deleting a bot activity.NOTE: We previously had
MessageDeleteActivityInputbut this was an invalid type on POST/PUT. Delete is a separate verb and needs its own path.This only partially resolves the issue named above. In addition to this change, I think we should make it more explicit in our docs.
Details:
conversation_ref(same pattern asctx.send())targeted=True(experimental, emitsExperimentalTeamsTargetedwarning)DELETE /v3/conversations/{id}/activities/{activityId}— no body, success = no exception