Skip to content

fix: HttpPlugin port check overwriting server instance created from server_factory #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevinwoodward wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: HttpPlugin port check overwriting server instance created from server_factory #358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions packages/apps/src/microsoft_teams/apps/http_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,13 +175,14 @@ async def on_start(self, event: PluginStartEvent) -> None:
self._port = event.port

try:
if self._server and self._server.config.port != self._port:
logger.warning(
"Using port configured by server factory: %d, but plugin start event has port %d.",
self._server.config.port,
self._port,
)
self._port = self._server.config.port
if self._server:
if self._server.config.port != self._port:
logger.warning(
"Using port configured by server factory: %d, but plugin start event has port %d.",
self._server.config.port,
self._port,
)
self._port = self._server.config.port
else:
config = uvicorn.Config(app=self.app, host="0.0.0.0", port=self._port, log_level="info")
self._server = uvicorn.Server(config)
Expand Down