Fix ExpressAdapter to accept Express app directly#504
Open
heyitsaamir wants to merge 7 commits intomainfrom
Open
Fix ExpressAdapter to accept Express app directly#504heyitsaamir wants to merge 7 commits intomainfrom
heyitsaamir wants to merge 7 commits intomainfrom
Conversation
These two markdown files are all a human needs to write — the e2e testing skill generates and manages the actual Playwright test code from here. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When users passed an http.Server that already had an Express app
(e.g. http.createServer(app)), the adapter created a second Express
app and attached it via server.on('request'), causing double request
handling and ERR_HTTP_HEADERS_SENT errors.
The constructor now accepts http.Server | express.Application:
- Express app: uses it directly, creates server from it (no double handling)
- http.Server: creates internal Express app, attaches to server
- Nothing: creates both (existing behavior)
Fixes #503
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ERR_HTTP_HEADERS_SENTwhen passing anhttp.Serverthat already has an Express app attached — the adapter no longer creates a second Express app in that scenarioExpressAdapterconstructor now acceptshttp.Server | express.Application | undefined:http.Serverfrom it (avoids double request handling)The original
http.Server-only constructor was designed to match theHttpPlugin's capabilities, but it led users into a trap: passinghttp.createServer(app)caused the adapter to attach a second Express app to the same server, resulting in double request handling. Accepting the Express app directly is the natural fix.Fixes #503
Test plan
express-adaptertests pass (9/9)