Skip to content

[openmvg] Fix linux build#43117

Closed
JackBoosY wants to merge 5 commits intomicrosoft:masterfrom
JackBoosY:jack/43106
Closed

[openmvg] Fix linux build#43117
JackBoosY wants to merge 5 commits intomicrosoft:masterfrom
JackBoosY:jack/43106

Conversation

@JackBoosY
Copy link
Copy Markdown
Contributor

@JackBoosY JackBoosY commented Jan 6, 2025

Fixes #43106

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

openmpi:arm-neon-android=fail
openmpi:arm64-android=fail
openmpi:x64-android=fail
openmvg:x64-linux=fail
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This record is added in #32014 (comment)
Either coin-or-clp or coin-or-osi or coinutils can be built on linux now.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This record is added in #32014 (comment) Either coin-or-clp or coin-or-osi or coinutils can be built on linux now.

The coin stuff was unblocked at that time, so the openmvg problem was no longer hidden by a cascade. It might have been investigated at that time.

@MonicaLiu0311 MonicaLiu0311 added the category:port-bug The issue is with a library, which is something the port should already support label Jan 6, 2025
@MonicaLiu0311 MonicaLiu0311 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Jan 6, 2025
endif()

vcpkg_cmake_config_fixup()
vcpkg_cmake_config_fixup(PACKAGE_NAME openMVG CONFIG_PATH lib/openMVG/cmake)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
vcpkg_cmake_config_fixup(PACKAGE_NAME openMVG CONFIG_PATH lib/openMVG/cmake)
vcpkg_cmake_config_fixup(CONFIG_PATH lib/openMVG/cmake)

PACKAGE_NAME only affects the chosen directory name. CMake is case-insensitive with regard to the directory name. We want the config to live in the lower-case directory openmvg which matches the port name. This is also the default PACKAGE_NAME.

@JackBoosY JackBoosY marked this pull request as draft January 14, 2025 08:44
@JackBoosY
Copy link
Copy Markdown
Contributor Author

I haven't linux machine so this issue is hard to be fixed on my side.

@MonicaLiu0311
Copy link
Copy Markdown
Contributor

MonicaLiu0311 commented Feb 20, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@PhoebeHui PhoebeHui assigned Mengna-Li and unassigned MonicaLiu0311 Apr 2, 2025
@BillyONeal
Copy link
Copy Markdown
Member

As far as I can tell this change appears to be no longer needed. Based on https://dev.azure.com/vcpkg/public/_build/results?buildId=121604&view=logs&j=f79cfdd7-47a8-597f-8f57-dc3e21a8f2ad&t=73c5513e-c47c-57a4-379a-581f7e429f13 openmvg is already passing on Linux.

Installing 1891/2641 openmvg[core,software]:x64-linux@2.1#2...
Building openmvg[core,software]:x64-linux@2.1#2...
Trying to download openMVG-openMVG-01193a245ee3c36458e650b1cf4402caad8983ef.tar.gz using asset cache https://vcpkgassetcachewus.blob.core.windows.net/cache/ee98ca26426e7129917c920cd59817cb5d4faf1f5aa12f4085f9ac431875e9ec23ffee7792d65286bad4b922c474c56d5c2f2008b38fddf1ede096644f13ad47?*** SECRET ***
Download successful! Asset cache hit, did not try authoritative source https://github.com/openMVG/openMVG/archive/01193a245ee3c36458e650b1cf4402caad8983ef.tar.gz
-- Extracting source /vcpkg/downloads/openMVG-openMVG-01193a245ee3c36458e650b1cf4402caad8983ef.tar.gz
-- Applying patch build_fixes.patch
-- Applying patch 0001-eigen_3.4.0.patch
-- Applying patch fast-c-language.diff
-- Applying patch no-absolute-paths.patch
-- Using source at /mnt/vcpkg-ci/b/openmvg/src/caad8983ef-270550d911.clean
-- Configuring x64-linux
-- Building x64-linux-dbg
-- Building x64-linux-rel
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_AlternativeVO' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_ChangeLocalOrigin' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_ColHarmonize' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_ComputeClusters' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_ComputeFeatures' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_ComputeMatches' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_ComputeSfM_DataColor' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_ComputeStructureFromKnownPoses' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_ComputeVLAD' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_ConvertList' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_ConvertSfM_DataFormat' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_ExportCameraFrustums' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_ExportUndistortedImages' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_FrustumFiltering' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_GeometricFilter' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_ListMatchingPairs' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_MatchesToTracks' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_PairGenerator' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_PointsFiltering' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_SfM' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_SfMInit_ImageListing' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_SfMInit_ImageListingFromKnownPoses' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_SfM_Localization' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_SplitMatchFileIntoMatchFiles' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_evalQuality' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_exportKeypoints' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_exportMatches' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_exportTracks' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_geodesy_registration_to_gps_position' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_openMVG2Agisoft' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_openMVG2CMPMVS' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_openMVG2Colmap' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_openMVG2MESHLAB' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_openMVG2MVE2' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_openMVG2MVSTEXTURING' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_openMVG2NVM' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_openMVG2PMVS' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_openMVG2WebGL' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_openMVG2openMVS' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/openMVG_main_openMVGSpherical2Cubic' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/ui_openMVG_MatchesViewer' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Adjusted RPATH of '/mnt/vcpkg-ci/p/openmvg_x64-linux/tools/openmvg/ui_openMVG_control_points_registration' (From '' -> To '$ORIGIN:$ORIGIN/../../lib')
-- Performing post-build validation
Starting submission of openmvg[core,software]:x64-linux@2.1#2 to 1 binary cache(s) in the background
Elapsed time to handle openmvg:x64-linux: 2.2 min

@BillyONeal
Copy link
Copy Markdown
Member

Indeed, #46409 appears to have already fixed this problem. Thanks for your contribution!

As this change no longer appears needed, I'm closing this PR.

@BillyONeal BillyONeal closed this Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[openmvg] Build error on x64-linux

5 participants