Add tool result message and error handling to LoggedToolCall #2647
+45
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndedLanguageModelToolResult
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the logging infrastructure for tool calls by adding error handling capabilities and result messages to the LoggedToolCall and ExtendedLanguageModelToolResult classes. The changes enable better debugging and error reporting for AI tool interactions.
Key Changes:
- Added
toolResultMessage,toolResultError, andhasErrorfields to track tool execution results and errors - Updated logging methods to extract and display these new fields in both JSON and markdown formats
- Extended the proposed VS Code API to include
toolResultErrorinExtendedLanguageModelToolResult
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/platform/requestLogger/node/requestLogger.ts |
Added optional fields to ILoggedToolCall interface for tool result message, error, and error flag |
src/extension/vscode.proposed.chatParticipantPrivate.d.ts |
Extended ExtendedLanguageModelToolResult class with toolResultError field |
src/extension/prompt/vscode-node/requestLoggerImpl.ts |
Implemented extraction and logging of new fields in LoggedToolCall class, updated toJSON and markdown rendering methods |
roblourens
reviewed
Dec 20, 2025
| result.push(`~~~`); | ||
| } | ||
|
|
||
| if (entry.toolResultMessage) { |
Member
There was a problem hiding this comment.
Are you going to parse this?
Member
Author
There was a problem hiding this comment.
no, it's just rendered as string in .copilotmd which seems fine to add.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the LoggedToolCall and ExtendedLanguageModelToolResult classes to include a tool result message, error handling, and a flag indicating if an error occurred. This improves logging and error reporting capabilities.
depending on core PR microsoft/vscode#284549