?workerModule -> ?esm #284458
Open
?workerModule -> ?esm #284458
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lszomoru
approved these changes
Dec 19, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the query parameter used for ESM worker module bundling from ?workerModule to ?esm. This standardizes the naming convention used when referring to TypeScript worker modules in bundler environments.
- Updated the documentation comment in
WebWorkerDescriptorto reflect the new query parameter - Updated all actual usages of the query parameter in worker module URL construction
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/vs/platform/webWorker/browser/webWorkerDescriptor.ts |
Updated documentation comment to specify ?esm instead of ?workerModule |
src/vs/workbench/services/extensions/browser/webWorkerExtensionHost.ts |
Changed query parameter from ?workerModule to ?esm for extension host worker |
src/vs/editor/browser/services/editorWorkerService.ts |
Changed query parameter from ?workerModule to ?esm for editor worker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.