Skip to content

Conversation

@gjsjohnmurray
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray commented Dec 19, 2025

This PR fixes #257550

image image

while avoiding changing how the command appears in Command Palette:

image

Copilot AI review requested due to automatic review settings December 19, 2025 16:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes the breadcrumb toggle option label to display "Breadcrumbs" instead of "Toggle Breadcrumbs" in context menus, addressing issue #257550.

  • Added a shortTitle property to the toggle breadcrumbs action
  • Updated the toggled.title to use the standardized "Breadcrumbs" label
  • Enabled short title rendering in the sticky scroll context menu

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/vs/workbench/browser/parts/editor/breadcrumbsControl.ts Added shortTitle property and updated toggled.title to use "Breadcrumbs" label for consistency
src/vs/editor/contrib/stickyScroll/browser/stickyScrollController.ts Enabled renderShortTitle option in context menu to display the new short title format

@gjsjohnmurray gjsjohnmurray marked this pull request as ready for review December 19, 2025 22:15
@vs-code-engineering
Copy link

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@bpasero

Matched files:

  • src/vs/workbench/browser/parts/editor/breadcrumbsControl.ts
  • src/vs/workbench/browser/parts/editor/editorGroupView.ts

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

super({
id: 'breadcrumbs.toggleFromEditorTitle',
title: localize2('notebook.toggleBreadcrumb', 'Toggle Breadcrumbs'),
title: localize2('notebook.toggleBreadcrumb', 'Breadcrumbs'),
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ToggleBreadcrumbFromEditorTitle action is inconsistent with the pattern used in ToggleLineNumberFromEditorTitle (line 119-120). While the title has been changed to "Breadcrumbs", the proper pattern would be to keep the full title as "Toggle Breadcrumbs" and add a shortTitle property (like shortTitle: localize2('cmd.toggle.short', 'Breadcrumbs')). This ensures consistency with other toggle actions and makes the action's purpose clear if the implementation changes in the future (e.g., if f1 is later set to true to allow Command Palette access).

Suggested change
title: localize2('notebook.toggleBreadcrumb', 'Breadcrumbs'),
title: localize2('notebook.toggleBreadcrumb', 'Toggle Breadcrumbs'),
shortTitle: localize2('cmd.toggle.short', 'Breadcrumbs'),

Copilot uses AI. Check for mistakes.
@bpasero bpasero assigned jrieken and unassigned Yoyokrazy Dec 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Toggle Breadcrumbs caption on editor header area's context menu is anomalous

3 participants