Add --package-lock-only to npm i flags #284597
Merged
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the npm completion spec from an upstream/external source to a VS Code-maintained implementation. The change removes 'npm' from the list of upstream specs and adds a new custom npm.ts file with the full npm command completion specification.
Key Changes
- Added custom npm completion spec at
extensions/terminal-suggest/src/completions/npm.tswith comprehensive npm command support - Removed 'npm' from the
upstreamSpecsarray inconstants.ts - Registered the new npm spec in
terminalSuggestMain.tsalongside other custom specs like git, gh, and npx
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
extensions/terminal-suggest/src/terminalSuggestMain.ts |
Added import and registration of the new npm completion spec |
extensions/terminal-suggest/src/constants.ts |
Removed 'npm' from the upstreamSpecs list to use the custom implementation instead |
extensions/terminal-suggest/src/completions/upstream/npm.ts |
Deleted the upstream npm spec file (1610 lines removed) |
extensions/terminal-suggest/src/completions/npm.ts |
Added new custom npm completion spec (1613 lines) with generators for package search, dependencies, and scripts |
roblourens
approved these changes
Dec 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #284593
Merge first: