ci: validate site builds on pull requests - #478
Closed
Shayne Boyer (spboyer) wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated pull-request workflow to validate the documentation site build before merging, while still producing a successful “skipped” required check for PRs that don’t touch site-related files.
Changes:
- Introduces
.github/workflows/site-ci.ymlwith aValidate sitejob designed to be required-check-friendly. - Detects whether a PR modifies
site/**or relevant workflow files (pages.yml,site-ci.yml) and conditionally runscd site && npm ci && npm run build. - Ensures non-site PRs still report a successful check via an explicit “Skip site build” step.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/site-ci.yml |
New PR workflow that conditionally builds the docs site and reports a successful skipped check when site files aren’t changed. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Low
| steps: | ||
| - name: Detect site changes | ||
| id: changes | ||
| uses: actions/github-script@v8 |
Member
Author
|
Superseded by #476. Closing duplicate candidate from parallel coding-agent fanout. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Site BuildPR workflow with a required-check-friendlyValidate sitejob.cd site && npm ci && npm run buildonly forsite/**, the site validation workflow, or the Pages workflow.Closes #473
Validation
git diff --checkcd site && npm ci && npm run buildcould not complete locally because the configured npm proxy returned 404 forplaywright-core-1.62.0.tgz; retrying against the public registry failed withENOTCONN.