ci: validate site builds on pull requests - #481
Closed
Shayne Boyer (spboyer) wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Pages workflow to validate the docs site build on pull requests targeting main, while keeping artifact upload and deployment disabled for PR events.
Changes:
- Add
pull_requestcoverage to run the site build validation before merge. - Add a
changesjob usingdorny/paths-filterto gate the site build to PRs that actually touchsite/**(or the Pages workflow). - Prevent Pages artifact upload and deployment on
pull_requestevents while preserving existing deploy behavior forpush/workflow_run.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/pages.yml | Adds PR-time site build validation with path filtering, and skips artifact upload/deploy on PRs. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Low
Comment on lines
17
to
21
| permissions: | ||
| contents: read | ||
| pages: write | ||
| pull-requests: read | ||
| id-token: write |
Comment on lines
+9
to
+11
| pull_request: | ||
| branches: [main] | ||
| types: [opened, synchronize, reopened, ready_for_review] |
Member
Author
|
Superseded by #476. Closing duplicate candidate from parallel coding-agent fanout. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cd site && npm ci && npm run buildvalidation before merge.site/**and.github/workflows/pages.ymlso non-site PRs still get a completed/skipped check instead of a pending required check.Closes #473
Validation
git diff --checkruby -e "require 'yaml'; YAML.load_file('.github/workflows/pages.yml')"Site change filterpassed, PagesBuildpassed, PagesDeployskipped on pull_request as intended, and all other PR checks passed or skipped.