Skip to content

Fix multiple consistency bugs#978

Merged
zhenchaoni merged 2 commits into
mainfrom
private/zhenni/fix_consistency_bug
Jun 26, 2026
Merged

Fix multiple consistency bugs#978
zhenchaoni merged 2 commits into
mainfrom
private/zhenni/fix_consistency_bug

Conversation

@zhenchaoni

@zhenchaoni zhenchaoni commented Jun 25, 2026

Copy link
Copy Markdown
Member

Fixes #565, #510

For #565 ,
For all command, use the shared device_op[tion and ep_option util. Therefore, all commands can have consistent CLI option name.

For #510 ,
Some URL in our project is still referencing the old wording "modelkit". Now change them to "winml"

@xieofxie

Copy link
Copy Markdown
Contributor

There are already two prs
https://github.com/microsoft/winml-cli/pull/818/changes
https://github.com/microsoft/winml-cli/pull/816/changes

Which is better? Should we merge the others first?

@zhenchaoni

Copy link
Copy Markdown
Member Author

There are already two prs https://github.com/microsoft/winml-cli/pull/818/changes https://github.com/microsoft/winml-cli/pull/816/changes

Which is better? Should we merge the others first?

@xieofxie The changes are basically the same. To avoid conflict, I will remove those duplicate changes in my PR. Then, this PR will not overlap with the other 2.

@zhenchaoni zhenchaoni merged commit a8b1bcf into main Jun 26, 2026
9 checks passed
@zhenchaoni zhenchaoni deleted the private/zhenni/fix_consistency_bug branch June 26, 2026 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cross-cutting] [P2] -d short used only by compile --device; everyone else uses --device with no short

2 participants