[dinwwwh]

Summary

Updated the fallback symbol key for asyncDispose to use Symbol.for('Symbol.asyncDispose') instead of Symbol.for('asyncDispose'), aligning with the standard used by esbuild, Babel, and core-js.

Key Changes

• Changed fallback symbol from Symbol.for('asyncDispose') to Symbol.for('Symbol.asyncDispose') to match ecosystem conventions
• Updated JSDoc comment to clarify the fallback behavior
• Removed unnecessary v8 ignore comments around the symbol initialization
• Added comprehensive test case verifying the fallback behavior when Symbol.asyncDispose is not natively available

Implementation Details

The fallback symbol is now consistent with how other major JavaScript tooling and libraries handle the asyncDispose symbol on runtimes that don't have native support. The test uses a Proxy to simulate an environment where Symbol.asyncDispose is undefined, ensuring the fallback mechanism works correctly and calls cleanup with the expected { kind: 'cancelled' } parameter.

https://claude.ai/code/session_01NRRM1bujEJiPEv7FbiLXDr

[pkg-pr-new]

• @standard-server/hono-node-playground
• @standard-server/node-http-playground

@standard-server/aws-lambda

npm i https://pkg.pr.new/@standard-server/aws-lambda@156

@standard-server/core

npm i https://pkg.pr.new/@standard-server/core@156

@standard-server/fastify

npm i https://pkg.pr.new/@standard-server/fastify@156

@standard-server/fetch

npm i https://pkg.pr.new/@standard-server/fetch@156

@standard-server/node

npm i https://pkg.pr.new/@standard-server/node@156

@standard-server/peer

npm i https://pkg.pr.new/@standard-server/peer@156

@standard-server/shared

npm i https://pkg.pr.new/@standard-server/shared@156

commit: 8a8e59b

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[codspeed]

Merging this PR will not alter performance

⚠️ 5 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

• octet stream 10KB
• json 10KB
• form data 10KB
• json 10KB
• json 10KB

✅ 26 untouched benchmarks
⏩ 108 skipped benchmarks¹

---

_{Comparing claude/dreamy-thompson-q5uqav (8a8e59b) with main (6c1cc3b)}

Footnotes

1. 108 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[pullfrog]

✅ No new issues found.

Reviewed changes — initial review of PR #156 (8a8e59b against base 6c1cc3b).

• Fallback symbol key corrected (packages/shared/src/iterator.ts) — the no-native-symbol fallback now uses Symbol.for('Symbol.asyncDispose') instead of Symbol.for('asyncDispose'), matching the key esbuild's __knownSymbol('asyncDispose'), Babel's usingCtx, and core-js's well-known-symbol polyfill all use.
• Comment/JSDoc updated — the stale "available in esnext" note is replaced with an accurate native-vs-fallback description; the two /* v8 ignore */ markers are dropped now that the fallback branch is exercised.
• Regression test added (packages/shared/src/iterator.test.ts) — stubs a Symbol proxy whose asyncDispose is undefined, re-imports the module, and asserts disposal dispatches under Symbol.for('Symbol.asyncDispose') with { kind: 'cancelled' }.

Verified locally against head 8a8e59b: packages/shared/src/iterator.test.ts passes (22 tests), iterator.ts reports 100% line/branch/function coverage, and pnpm run check (sherif, oxlint, oxfmt, tsc) is clean. I confirmed the fallback key against the actual upstream sources — esbuild's __using uses __knownSymbol('asyncDispose') → Symbol.for('Symbol.asyncDispose'), Babel's usingCtx uses Symbol.asyncDispose || Symbol.for("Symbol.asyncDispose"), and core-js resolves well-known symbols to Symbol.for('Symbol.' + name) without native support. This closes a real interop gap for await using on runtimes without a native Symbol.asyncDispose, while leaving the native path unchanged.

  ^{｜ View workflow run ｜ Using deepseek-v4.1-flash (free via Pullfrog for OSS) ｜ 𝕏}