fix(peer): release client request state once a streamed response finishes

[dinwwwh]

Summary

This PR fixes a resource leak where streaming response bodies (event-stream and octet-stream) were not properly released when the stream completed, even if the body was never resolved by the client. This caused request state to persist indefinitely and event listeners to accumulate.

Key Changes

• Client peer streaming message handling: Modified ClientPeer to automatically close requests when receiving final stream messages:

  • For event-stream: close on 'close' or 'error' events
  • For octet-stream: close when the close flag is set to true

• Test coverage: Added comprehensive tests to verify:

  • Requests are released when streaming bodies complete without being resolved
  • Event listeners are properly cleaned up on stream completion
  • No cancel messages are sent when iterating over already-finished streams
  • Integration tests confirming both client and server peers release resources correctly
  • Proper cleanup of abort signal listeners even with 100 concurrent requests

Implementation Details

The fix ensures that the server's stream completion message (which indicates the server has already released its resources) triggers an immediate cleanup on the client side via closeById(id). This prevents the accumulation of request state and event listeners that would otherwise only be cleaned up when the body is eventually resolved or garbage collected.

https://claude.ai/code/session_01AEr5Gq656PLdpCLEAw2zht

[pkg-pr-new]

• @standard-server/hono-node-playground
• @standard-server/node-http-playground

@standard-server/aws-lambda

npm i https://pkg.pr.new/@standard-server/aws-lambda@157

@standard-server/core

npm i https://pkg.pr.new/@standard-server/core@157

@standard-server/fastify

npm i https://pkg.pr.new/@standard-server/fastify@157

@standard-server/fetch

npm i https://pkg.pr.new/@standard-server/fetch@157

@standard-server/node

npm i https://pkg.pr.new/@standard-server/node@157

@standard-server/peer

npm i https://pkg.pr.new/@standard-server/peer@157

@standard-server/shared

npm i https://pkg.pr.new/@standard-server/shared@157

commit: 81661f4

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[codspeed]

Merging this PR will not alter performance

⚠️ 4 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

• json 10KB
• json 10KB
• octet stream 10KB
• form data 10KB

✅ 26 untouched benchmarks
⏩ 108 skipped benchmarks¹

---

_{Comparing claude/sleepy-fermat-d65qs9 (81661f4) with main (6c1cc3b)}

Footnotes

1. 108 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[pullfrog]

✅ No new issues found.

Reviewed changes

This run reviewed the full PR (all 5 commits) against main.

• Eager release on terminal stream message (packages/peer/src/client.ts) — ClientPeer.message() now calls closeById(id) when an event-stream message is 'close'/'error' or an octet-stream message has close: true, instead of waiting for the consumer to resolve/consume the body.
• Unit coverage (packages/peer/src/client.test.ts) — release without resolving the body for event-stream close and error, no cancel sent when return()/reader.cancel() runs on an already-finished stream, and abort-listener removal asserted via a spy.
• Integration coverage (packages/peer/tests/peer.test.ts) — 100 concurrent streamed responses left unresolved drain both peers' requests to 0 with no residual abort listeners, plus an endless stream cancelled without reading finalizes the server generator.

The ordering is sound: the terminal message is pushed before closeById, so Queue.close keeps it buffered and pullable (only pending pulls are rejected), and closeById is idempotent against the later AsyncIteratorClass/toOctetStream cleanup. Peer suite (273 tests) passes locally.

  ^{｜ View workflow run ｜ Using deepseek-v4.1-flash (free via Pullfrog for OSS) ｜ 𝕏}