Skip to content

Make upstream repo selectable at build-time #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cbs228 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make upstream repo selectable at build-time #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,15 @@ RUN apt-get update && \
useradd -m minecraft -u 1000 -g 1000 && \
mkdir -p /home/minecraft/render /home/minecraft/server

RUN git clone --depth=1 https://github.com/overviewer/Minecraft-Overviewer.git
ARG OVERVIEWER_REPOSITORY=https://github.com/overviewer/Minecraft-Overviewer.git
ARG OVERVIEWER_BRANCH=

RUN printf "Cloning from <%s>, branch %s…\n" "${OVERVIEWER_REPOSITORY}" "${OVERVIEWER_BRANCH:-HEAD}"; \
if [ -n "$OVERVIEWER_BRANCH" ]; then \
git clone --depth=1 --branch "${OVERVIEWER_BRANCH}" "${OVERVIEWER_REPOSITORY}" Minecraft-Overviewer; \
else \
git clone --depth=1 "${OVERVIEWER_REPOSITORY}" Minecraft-Overviewer; \
fi

WORKDIR /home/minecraft/Minecraft-Overviewer/
RUN python3 setup.py build && \
Expand All @@ -79,7 +87,7 @@ COPY entrypoint.sh /home/minecraft/entrypoint.sh
COPY download_url.py /home/minecraft/download_url.py

# Add some timestamps / build information into the image
RUN printf "GITHUB_REF=%s\nGITHUB_REPOSITORY=%s\nGITHUB_SHA=%s\nBUILD_DATE=$(date -u)\n" "$GITHUB_REF" "$GITHUB_REPOSITORY" "$GITHUB_SHA" > /home/minecraft/build-details.txt
RUN printf "GITHUB_REF=%s\nGITHUB_REPOSITORY=%s\nGITHUB_SHA=%s\nBUILD_DATE=$(date -u)\nOVERVIEWER_REPOSITORY=%s\nOVERVIEWER_BRANCH=%s\nOVERVIEWER_SHA=$(git -C Minecraft-Overviewer log -1 --pretty='%H')\n" "$GITHUB_REF" "$GITHUB_REPOSITORY" "$GITHUB_SHA" "$OVERVIEWER_REPOSITORY" "$OVERVIEWER_BRANCH" > /home/minecraft/build-details.txt

RUN chown minecraft:minecraft -R /home/minecraft/

Expand Down