Repository navigation
[pull] main from UsefulSoftwareCo:main - #40
Merged
Merged
Conversation
Isolates ARE reused - those serving a page request had already served a median of 19 spans across 3 paths - they are just never warm for Start, because /mcp returns before fetchHandler. Two import-based warmups (#1679, #1681) moved nothing: loadEntries awaits three specifiers plus a separately cached manifest, so warming a subset leaves the request paying for the rest. Drive the real handler instead; it populates whatever those caches are and cannot drift with Start's internals.
* Revert "Fix lint: do not stringify the unknown warmup error (#1688)" This reverts commit 1c57887. * Revert "Log whether the warmup runs and whether warm isolates still pay for Start (#1687)" This reverts commit 1b2509c. * Revert "Warm the Start graph by replaying a real request per isolate (#1686)" This reverts commit 46625d2. * Reapply "Warm the Start server graph on isolate first fetch (#1681)" (#1682) This reverts commit aff1f39. * Revert "Warm the Start server graph on isolate first fetch (#1681)" This reverts commit 29a0aea. * Reapply "Warm the Start server graph on isolates that persist (#1679)" (#1680) This reverts commit 332955f. * Revert "Warm the Start server graph on isolates that persist (#1679)" This reverts commit ca9617e.
#1690) Reverts 0b1739b. Restores the SDK v1 stack and the Cloudflare Agents McpAgent bridge for /mcp. Dependent work is reverted with it, since it patched code that only exists under the v2 stack: the dead-session negative cache (#1627) and its tests, and the standalone-listener/keepalive changes (#1622, #1629, #1632) that live in the deleted v2 modules. Kept on top of the revert: the passthrough proxies at the Worker entry (#1678), version stamping and dispatch spans (#1664), and MCP request tracing, rewired through traceCloudMcpRequest since the v1 handler takes no traceRequest option. Dependencies: agents is pinned to 0.17.3 so patchedDependencies applies (a floating ^0.17.3 resolved to 0.17.4 and silently dropped the patch). bun.lock is reconciled from main rather than reverted wholesale, which otherwise split ajv across 8.18/8.20 and broke codemode-core typecheck.
… (#1691) Reverts b6e8c68. Reverting #1611 did not change page latency, so it is not the cause of the regression; restore MCP spec 2026-07-28 serving, the SDK v2 stack, and the dependent reconnect-storm fixes (#1622, #1627, #1629, #1632) that went with it. Tree is identical to the pre-revert commit.
Page latency broke 2026-08-16 between 20:40-20:50 UTC. Both code commits from that window have now been reverted to production and neither moved it, and the built bundle is unchanged across them, so the regression is not in that code. Targeted placement is the remaining variable from that era that has never been tested honestly - the earlier comparison used a workers.dev URL that served different content and never ran the app. One line, instantly revertible.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )