Open
Conversation
- Add DiodeLadderFilter based on Will Pirkle's analysis - Implement 4-pole diode ladder with TB-303 octave mode option - Add FilterType enum (TeeBee, Diode, DiodeOctave) - Integrate filter selection into Open303 synth engine - Include passband gain compensation and input drive 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add three distinct nonlinearity stages modeling real diode behavior: 1. diodeShape() - asymmetric input saturation (exp on positive, linear negative) 2. fbShape() - feedback path saturation for resonance collapse/chirp 3. stageNL() - per-stage cubic nonlinearity for grit under drive - Add DC blocker to prevent low-frequency buildup - Remove chowdsp math_approx dependency (use std::exp directly) - Add detailed signal flow documentation in header 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- AC-coupled input signal modulates filter cutoff at audio rate - One-pole HPF (~20Hz) removes DC before modulation - Creates FM sidebands, talking/screaming character with resonance - New setFilterFmDepth() API (0-100%) Based on Devilfish mod: "Filter FM uses the output of the VCA, AC coupled into the filter cutoff frequency" 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setFilterFmDepth()API (0-100%)Based on Devilfish mod: "Filter FM uses the output of the VCA, AC coupled into the filter cutoff frequency"
Dependencies
Test plan
🤖 Generated with Claude Code