fix: prevent HTML tag duplication in ZIP export#286
Open
martinezharo wants to merge 1 commit intomidudev:mainfrom
Open
fix: prevent HTML tag duplication in ZIP export#286martinezharo wants to merge 1 commit intomidudev:mainfrom
martinezharo wants to merge 1 commit intomidudev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when exporting code as a ZIP file, the
index.htmlis generated by wrapping the user's input within a static template. This causes structural issues and tag duplication (e.g., double<html>or<body>tags) if the user provides a complete HTML boilerplate.This PR introduces a smart wrapping logic that detects existing structural elements and only injects the missing parts, ensuring a valid and clean HTML document.
Changes
src/download.js: Replaced the hardcoded template literal increateZipWithMultipleFileswith a dedicatedbuildIndexHtmlhelper function.buildIndexHtml: Added logic to conditionally inject the following elements only if they are missing:<!DOCTYPE html><html lang="en"><head>(including the<link>tostyle.css)<body><script type="module" src="script.js">Benefits
<body class="dark">or<html lang="es">).Testing Performed
<h1>Hello</h1>) is correctly wrapped in a full template.neostandard.