Say what changed in the update dialog - #7
Merged
Merged
Conversation
The feed announced a new version and described it with nothing, so the only thing in front of somebody about to press Install was the version number. Sparkle takes per-version notes from a file named after the archive in the directory generate_appcast scans, so appcast.sh now cuts this version's section out of CHANGELOG.md, turns it into the small amount of HTML the changelog actually uses, and leaves it there in the staging directory - nothing new lands in dist/. The styling follows the Mac's light or dark appearance rather than fixing black on white, which Sparkle's web view would render unreadable at night. A release whose version has no section, or whose section converts to nothing, now fails instead of publishing the blank dialog it was supposed to fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.3.3 gave the app real auto-update, but the feed it publishes carries no release notes — only a link. So Sparkle announces a new version and shows an empty page, and the only way to learn what you are about to install is to go and look the changelog up. People press Install without reading anything.
The release script now extracts that version's own section from
CHANGELOG.md, converts it to a small HTML fragment and hands it togenerate_appcastunder the name Sparkle looks for, with--embed-release-notesso it goes into the feed rather than staying a link. The styling is deliberately plain and usescolor-scheme: light dark, so it follows the Mac's appearance instead of forcing black on white into a dark window.A release whose version has nothing written about it in the changelog is now refused rather than published with an empty dialog — the same shape as the guards already in that script.
Also in here: the self-check used to create a skill called
auto-testeand a command calledauto-comando, described in Portuguese, on the disk of anyone who ran it. Those are nowself-check-skillandself-check-command, and the last Portuguese strings in the scripts and comments are gone.Verified against a locally built and signed image, not notarised or published: the
<description>comes out embedded and escaped (&,<, links intact),xmllintpasses, and the existing guards still hold — the disk image is signed, the feed is signed, and it points at the-updatecopy. 299 tests, 0 failures.