Skip to content

🧪 [transfer-pvc indirect] Add unit test for --cloud-storage whitespace trimming - #939

Open
nachandr wants to merge 1 commit into
migtools:mainfrom
nachandr:unit_test_whitespace
Open

🧪 [transfer-pvc indirect] Add unit test for --cloud-storage whitespace trimming#939
nachandr wants to merge 1 commit into
migtools:mainfrom
nachandr:unit_test_whitespace

Conversation

@nachandr

@nachandr nachandr commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Tests
    • Added coverage to verify that cloud storage values are trimmed correctly.
    • Added validation coverage for whitespace-only values.
    • Confirmed that empty values remain supported.

Signed-off-by: Nandini Chandra <nachandr@redhat.com>
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: b1223148-4183-4375-b598-39882bd84e91

📥 Commits

Reviewing files that changed from the base of the PR and between 21ab234 and 2096ffa.

📒 Files selected for processing (1)
  • cmd/transfer-pvc/transfer-pvc_test.go

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The test suite adds temporary kubeconfig setup and table-driven coverage for Complete() cloud-storage normalization.

Changes

Transfer PVC validation

Layer / File(s) Summary
Cloud storage normalization coverage
cmd/transfer-pvc/transfer-pvc_test.go
Adds temporary kubeconfig creation and verifies trimming of surrounding whitespace, rejection of whitespace-only values, and acceptance of empty values.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 2096f

This adds unit coverage for cloud-storage whitespace handling without changing production behavior. No current merge-blocking risk is identified.

Suggested reviewers: stillalearner, msajidmansoori12, tamar-dinavetsky

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the addition of a unit test for trimming whitespace from the --cloud-storage value. The test scope matches the pull request changes.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Test Coverage Report

Total: 50.2%

Per-package coverage

  • github.com/konveyor/crane — 0.0%
  • github.com/konveyor/crane/cmd/apply — 50.6%
  • github.com/konveyor/crane/cmd/convert — 0.0%
  • github.com/konveyor/crane/cmd/export — 93.9%
  • github.com/konveyor/crane/cmd/plugin-manager — 0.0%
  • github.com/konveyor/crane/cmd/plugin-manager/add — 0.0%
  • github.com/konveyor/crane/cmd/plugin-manager/list — 0.0%
  • github.com/konveyor/crane/cmd/plugin-manager/remove — 0.0%
  • github.com/konveyor/crane/cmd/skopeo-sync-gen — 0.0%
  • github.com/konveyor/crane/cmd/transfer-pvc — 41.9%
  • github.com/konveyor/crane/cmd/transform — 59.8%
  • github.com/konveyor/crane/cmd/transform/listplugins — 21.1%
  • github.com/konveyor/crane/cmd/transform/optionals — 0.0%
  • github.com/konveyor/crane/cmd/tunnel-api — 0.0%
  • github.com/konveyor/crane/cmd/validate — 69.7%
  • github.com/konveyor/crane/cmd/version — 20.0%
  • github.com/konveyor/crane/internal/apply — 29.5%
  • github.com/konveyor/crane/internal/audit — 90.2%
  • github.com/konveyor/crane/internal/buildinfo — 100.0%
  • github.com/konveyor/crane/internal/cli — 100.0%
  • github.com/konveyor/crane/internal/file — 85.7%
  • github.com/konveyor/crane/internal/flags — 0.0%
  • github.com/konveyor/crane/internal/kustomize — 83.2%
  • github.com/konveyor/crane/internal/log — 0.0%
  • github.com/konveyor/crane/internal/plugin — 32.9%
  • github.com/konveyor/crane/internal/transform — 82.0%
  • github.com/konveyor/crane/internal/validate — 57.7%
Full function-level details
github.com/konveyor/crane/cmd/apply/apply.go:45:			Complete								100.0%
github.com/konveyor/crane/cmd/apply/apply.go:54:			Validate								83.3%
github.com/konveyor/crane/cmd/apply/apply.go:72:			Run									0.0%
github.com/konveyor/crane/cmd/apply/apply.go:76:			NewApplyCommand								0.0%
github.com/konveyor/crane/cmd/apply/apply.go:119:			getStageNames								100.0%
github.com/konveyor/crane/cmd/apply/apply.go:127:			addFlagsForOptions							0.0%
github.com/konveyor/crane/cmd/apply/apply.go:140:			run									71.2%
github.com/konveyor/crane/cmd/convert/convert.go:33:			NewConvertOptions							0.0%
github.com/konveyor/crane/cmd/convert/convert.go:62:			addFlagsForConvertOptions						0.0%
github.com/konveyor/crane/cmd/convert/convert.go:73:			Complete								0.0%
github.com/konveyor/crane/cmd/convert/convert.go:82:			Run									0.0%
github.com/konveyor/crane/cmd/convert/convert.go:86:			run									0.0%
github.com/konveyor/crane/cmd/convert/convert.go:112:			getClientFromContext							0.0%
github.com/konveyor/crane/cmd/convert/convert.go:134:			getRestConfigFromContext						0.0%
github.com/konveyor/crane/cmd/export/cluster.go:29:			NewClusterScopeHandler							100.0%
github.com/konveyor/crane/cmd/export/cluster.go:35:			isClusterScopedResource							100.0%
github.com/konveyor/crane/cmd/export/cluster.go:44:			filterRbacResources							100.0%
github.com/konveyor/crane/cmd/export/cluster.go:102:			NewClusterScopedRbacHandler						100.0%
github.com/konveyor/crane/cmd/export/cluster.go:113:			exportedSANamespaces							100.0%
github.com/konveyor/crane/cmd/export/cluster.go:127:			groupMatchesExportedSANamespaces					100.0%
github.com/konveyor/crane/cmd/export/cluster.go:144:			parseServiceAccountUserSubject						100.0%
github.com/konveyor/crane/cmd/export/cluster.go:155:			prepareForFiltering							100.0%
github.com/konveyor/crane/cmd/export/cluster.go:188:			filteredResourcesOfKind							100.0%
github.com/konveyor/crane/cmd/export/cluster.go:214:			accept									100.0%
github.com/konveyor/crane/cmd/export/cluster.go:224:			acceptClusterRoleBinding						100.0%
github.com/konveyor/crane/cmd/export/cluster.go:261:			acceptClusterRole							100.0%
github.com/konveyor/crane/cmd/export/cluster.go:285:			acceptSecurityContextConstraints					100.0%
github.com/konveyor/crane/cmd/export/cluster.go:337:			anyServiceAccountInNamespace						100.0%
github.com/konveyor/crane/cmd/export/crd.go:18:				normalizeGroupSet							85.7%
github.com/konveyor/crane/cmd/export/crd.go:30:				shouldSkipCRDGroup							100.0%
github.com/konveyor/crane/cmd/export/crd.go:51:				crdFailureAPIResourceName						100.0%
github.com/konveyor/crane/cmd/export/crd.go:57:				getOperatorManager							92.9%
github.com/konveyor/crane/cmd/export/crd.go:89:				collectRelatedCRDs							95.0%
github.com/konveyor/crane/cmd/export/discover.go:41:			hasClusterScopedManifests						100.0%
github.com/konveyor/crane/cmd/export/discover.go:59:			prepareClusterResourceDir						100.0%
github.com/konveyor/crane/cmd/export/discover.go:75:			prepareFailuresDir							100.0%
github.com/konveyor/crane/cmd/export/discover.go:87:			writeResources								85.7%
github.com/konveyor/crane/cmd/export/discover.go:135:			writeErrors								83.3%
github.com/konveyor/crane/cmd/export/discover.go:178:			discoverPreferredResources						100.0%
github.com/konveyor/crane/cmd/export/discover.go:209:			resourceToExtract							100.0%
github.com/konveyor/crane/cmd/export/discover.go:286:			isAdmittedResource							100.0%
github.com/konveyor/crane/cmd/export/discover.go:295:			getObjects								96.3%
github.com/konveyor/crane/cmd/export/discover.go:346:			iterateItemsByGet							90.9%
github.com/konveyor/crane/cmd/export/discover.go:382:			iterateItemsInList							92.3%
github.com/konveyor/crane/cmd/export/export.go:56:			Complete								88.6%
github.com/konveyor/crane/cmd/export/export.go:118:			Validate								100.0%
github.com/konveyor/crane/cmd/export/export.go:168:			validateExportNamespace							87.5%
github.com/konveyor/crane/cmd/export/export.go:185:			allResourceListsForbidden						87.5%
github.com/konveyor/crane/cmd/export/export.go:203:			mergeImpersonationExtras						100.0%
github.com/konveyor/crane/cmd/export/export.go:218:			Run									0.0%
github.com/konveyor/crane/cmd/export/export.go:359:			NewExportCommand							51.7%
github.com/konveyor/crane/cmd/export/gk_filter.go:23:			ParseGroupKind								100.0%
github.com/konveyor/crane/cmd/export/gk_filter.go:50:			Matches									100.0%
github.com/konveyor/crane/cmd/export/gk_filter.go:62:			String									100.0%
github.com/konveyor/crane/cmd/export/gk_filter.go:76:			NewGKFilter								100.0%
github.com/konveyor/crane/cmd/export/gk_filter.go:105:			ShouldInclude								100.0%
github.com/konveyor/crane/cmd/export/gk_filter.go:145:			IsEmpty									100.0%
github.com/konveyor/crane/cmd/plugin-manager/add/add.go:44:		Complete								0.0%
github.com/konveyor/crane/cmd/plugin-manager/add/add.go:51:		Validate								0.0%
github.com/konveyor/crane/cmd/plugin-manager/add/add.go:102:		Run									0.0%
github.com/konveyor/crane/cmd/plugin-manager/add/add.go:106:		NewAddCommand								0.0%
github.com/konveyor/crane/cmd/plugin-manager/add/add.go:137:		addFlagsForOptions							0.0%
github.com/konveyor/crane/cmd/plugin-manager/add/add.go:142:		run									0.0%
github.com/konveyor/crane/cmd/plugin-manager/add/add.go:220:		downloadBinary								0.0%
github.com/konveyor/crane/cmd/plugin-manager/add/add.go:279:		binaryURIForPlatform							0.0%
github.com/konveyor/crane/cmd/plugin-manager/list/list.go:48:		Complete								0.0%
github.com/konveyor/crane/cmd/plugin-manager/list/list.go:55:		Validate								0.0%
github.com/konveyor/crane/cmd/plugin-manager/list/list.go:60:		Run									0.0%
github.com/konveyor/crane/cmd/plugin-manager/list/list.go:64:		NewListCommand								0.0%
github.com/konveyor/crane/cmd/plugin-manager/list/list.go:94:		addFlagsForOptions							0.0%
github.com/konveyor/crane/cmd/plugin-manager/list/list.go:102:		run									0.0%
github.com/konveyor/crane/cmd/plugin-manager/list/list.go:177:		printInstalledInformation						0.0%
github.com/konveyor/crane/cmd/plugin-manager/list/list.go:187:		groupInformationForPlugins						0.0%
github.com/konveyor/crane/cmd/plugin-manager/list/list.go:206:		printInformation							0.0%
github.com/konveyor/crane/cmd/plugin-manager/list/list.go:218:		printParamsInformation							0.0%
github.com/konveyor/crane/cmd/plugin-manager/list/list.go:232:		getOptionalFields							0.0%
github.com/konveyor/crane/cmd/plugin-manager/list/list.go:257:		printTable								0.0%
github.com/konveyor/crane/cmd/plugin-manager/plugin-manager.go:33:	Complete								0.0%
github.com/konveyor/crane/cmd/plugin-manager/plugin-manager.go:38:	Validate								0.0%
github.com/konveyor/crane/cmd/plugin-manager/plugin-manager.go:43:	Run									0.0%
github.com/konveyor/crane/cmd/plugin-manager/plugin-manager.go:47:	NewPluginManagerCommand							0.0%
github.com/konveyor/crane/cmd/plugin-manager/plugin-manager.go:78:	addFlagsForOptions							0.0%
github.com/konveyor/crane/cmd/plugin-manager/plugin-manager.go:86:	run									0.0%
github.com/konveyor/crane/cmd/plugin-manager/remove/remove.go:35:	Complete								0.0%
github.com/konveyor/crane/cmd/plugin-manager/remove/remove.go:42:	Validate								0.0%
github.com/konveyor/crane/cmd/plugin-manager/remove/remove.go:47:	Run									0.0%
github.com/konveyor/crane/cmd/plugin-manager/remove/remove.go:51:	NewRemoveCommand							0.0%
github.com/konveyor/crane/cmd/plugin-manager/remove/remove.go:81:	run									0.0%
github.com/konveyor/crane/cmd/skopeo-sync-gen/skopeo-sync-gen.go:61:	Complete								0.0%
github.com/konveyor/crane/cmd/skopeo-sync-gen/skopeo-sync-gen.go:66:	Validate								0.0%
github.com/konveyor/crane/cmd/skopeo-sync-gen/skopeo-sync-gen.go:70:	NewSkopeoSyncGenCommand							0.0%
github.com/konveyor/crane/cmd/skopeo-sync-gen/skopeo-sync-gen.go:104:	shouldAddImageStream							0.0%
github.com/konveyor/crane/cmd/skopeo-sync-gen/skopeo-sync-gen.go:115:	Run									0.0%
github.com/konveyor/crane/cmd/transfer-pvc/indirect.go:31:		runIndirect								0.0%
github.com/konveyor/crane/cmd/transfer-pvc/indirect.go:239:		followPodLogsUntilComplete						0.0%
github.com/konveyor/crane/cmd/transfer-pvc/indirect.go:334:		checkRclonePartialSuccess						87.5%
github.com/konveyor/crane/cmd/transfer-pvc/indirect.go:387:		validateRcloneConfigSecret						100.0%
github.com/konveyor/crane/cmd/transfer-pvc/indirect.go:411:		createTempRcloneSecretFromData						0.0%
github.com/konveyor/crane/cmd/transfer-pvc/indirect.go:454:		generateCryptSection							62.5%
github.com/konveyor/crane/cmd/transfer-pvc/indirect.go:471:		rcloneObscure								69.2%
github.com/konveyor/crane/cmd/transfer-pvc/progress.go:39:		NewRsyncLogStream							0.0%
github.com/konveyor/crane/cmd/transfer-pvc/progress.go:53:		Init									0.0%
github.com/konveyor/crane/cmd/transfer-pvc/progress.go:146:		writeProgressToFile							100.0%
github.com/konveyor/crane/cmd/transfer-pvc/progress.go:156:		Close									0.0%
github.com/konveyor/crane/cmd/transfer-pvc/progress.go:162:		Streams									0.0%
github.com/konveyor/crane/cmd/transfer-pvc/progress.go:166:		ExitCode								0.0%
github.com/konveyor/crane/cmd/transfer-pvc/progress.go:205:		addDataSize								100.0%
github.com/konveyor/crane/cmd/transfer-pvc/progress.go:230:		String									100.0%
github.com/konveyor/crane/cmd/transfer-pvc/progress.go:234:		MarshalJSON								100.0%
github.com/konveyor/crane/cmd/transfer-pvc/progress.go:238:		AsString								100.0%
github.com/konveyor/crane/cmd/transfer-pvc/progress.go:286:		NewProgress								100.0%
github.com/konveyor/crane/cmd/transfer-pvc/progress.go:306:		Completed								100.0%
github.com/konveyor/crane/cmd/transfer-pvc/progress.go:311:		Status									100.0%
github.com/konveyor/crane/cmd/transfer-pvc/progress.go:336:		Merge									91.2%
github.com/konveyor/crane/cmd/transfer-pvc/progress.go:391:		newDataSize								81.8%
github.com/konveyor/crane/cmd/transfer-pvc/progress.go:414:		parseRsyncLogs								76.1%
github.com/konveyor/crane/cmd/transfer-pvc/progress.go:494:		waitForPodRunning							0.0%
github.com/konveyor/crane/cmd/transfer-pvc/progress.go:528:		getFinalPodStatus							0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:102:		Validate								83.3%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:130:		Validate								55.6%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:146:		NewTransferPVCCommand							0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:182:		addFlagsToTransferPVCCommand						0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:207:		Complete								86.4%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:246:		Validate								61.9%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:313:		Run									0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:323:		isIntraClusterSameNamespace						100.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:329:		getClientFromContext							0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:350:		getRestConfigFromContext						0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:357:		run									0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:696:		certificateSecretName							100.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:705:		getValidatedResourceName						66.7%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:715:		getNodeNameForPVC							0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:735:		getIDsForNamespace							77.8%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:798:		getSecurityContextFromWorkload						74.5%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:898:		podSpecReferencesPVC							100.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:907:		extractPodSecurityContext						90.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:957:		inspectPVCFileOwnership							75.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1061:	getSourcePodSecurityContext						0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1065:	getTargetPodSecurityContext						0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1071:	rsyncTransferImage							100.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1078:	garbageCollect								0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1115:	deleteResourcesIteratively						0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1141:	deleteResourcesForGVK							0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1164:	followClientLogs							0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1193:	waitForEndpoint								0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1205:	createEndpoint								0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1250:	getRouteHostName							0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1267:	truncateWithHash							100.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1273:	buildDestinationPVC							0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1294:	createDestinationPVC							80.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1321:	stripServerManagedPVCAnnotations					100.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1338:	isServerManagedPVCAnnotation						100.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1355:	ApplyTo									0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1375:	ApplyTo									100.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1388:	ApplyTo									0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1404:	String									0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1408:	Set									0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1418:	Type									0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1424:	parseSourceDestinationMapping						100.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1446:	String									0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1450:	Set									0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1459:	Type									0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1463:	String									0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1467:	Set									0.0%
github.com/konveyor/crane/cmd/transfer-pvc/transfer-pvc.go:1477:	Type									0.0%
github.com/konveyor/crane/cmd/transform/listplugins/listplugins.go:34:	Complete								0.0%
github.com/konveyor/crane/cmd/transform/listplugins/listplugins.go:41:	Validate								0.0%
github.com/konveyor/crane/cmd/transform/listplugins/listplugins.go:46:	Run									0.0%
github.com/konveyor/crane/cmd/transform/listplugins/listplugins.go:50:	NewListPluginsCommand							0.0%
github.com/konveyor/crane/cmd/transform/listplugins/listplugins.go:83:	GetPluginNames								87.5%
github.com/konveyor/crane/cmd/transform/listplugins/listplugins.go:99:	getFilteredPlugins							60.0%
github.com/konveyor/crane/cmd/transform/listplugins/listplugins.go:109:	run									0.0%
github.com/konveyor/crane/cmd/transform/optionals/optionals.go:33:	Complete								0.0%
github.com/konveyor/crane/cmd/transform/optionals/optionals.go:40:	Validate								0.0%
github.com/konveyor/crane/cmd/transform/optionals/optionals.go:45:	Run									0.0%
github.com/konveyor/crane/cmd/transform/optionals/optionals.go:49:	NewOptionalsCommand							0.0%
github.com/konveyor/crane/cmd/transform/optionals/optionals.go:81:	run									0.0%
github.com/konveyor/crane/cmd/transform/transform.go:57:		Complete								0.0%
github.com/konveyor/crane/cmd/transform/transform.go:65:		Validate								76.5%
github.com/konveyor/crane/cmd/transform/transform.go:90:		Run									0.0%
github.com/konveyor/crane/cmd/transform/transform.go:95:		getPluginCompletions							100.0%
github.com/konveyor/crane/cmd/transform/transform.go:121:		NewTransformCommand							0.0%
github.com/konveyor/crane/cmd/transform/transform.go:166:		addFlagsForOptions							0.0%
github.com/konveyor/crane/cmd/transform/transform.go:186:		run									11.0%
github.com/konveyor/crane/cmd/transform/transform.go:393:		parseStageOptionals							100.0%
github.com/konveyor/crane/cmd/transform/transform.go:426:		optionalFlagsToLowerChecked						100.0%
github.com/konveyor/crane/cmd/transform/transform.go:440:		runStageWithCleanup							0.0%
github.com/konveyor/crane/cmd/transform/transform.go:456:		reconcileInstructionStages						70.8%
github.com/konveyor/crane/cmd/transform/transform.go:502:		ensurePreviousStagesRun							71.4%
github.com/konveyor/crane/cmd/transform/transform.go:520:		ensureStagesHaveOutput							93.3%
github.com/konveyor/crane/cmd/transform/transform.go:559:		createDefaultStagesForAllPlugins					90.0%
github.com/konveyor/crane/cmd/transform/transform.go:612:		validateStageNameToken							100.0%
github.com/konveyor/crane/cmd/transform/transform.go:627:		findStageByDirName							100.0%
github.com/konveyor/crane/cmd/transform/transform.go:639:		findStagesByName							100.0%
github.com/konveyor/crane/cmd/transform/transform.go:651:		createStageDirectory							77.8%
github.com/konveyor/crane/cmd/transform/transform.go:672:		createCustomStageWithExplicitName					100.0%
github.com/konveyor/crane/cmd/transform/transform.go:688:		createCustomStageWithAutoPriority					66.7%
github.com/konveyor/crane/cmd/transform/transform.go:712:		createPluginStage							0.0%
github.com/konveyor/crane/cmd/transform/transform.go:748:		resolveAndValidateStages						57.0%
github.com/konveyor/crane/cmd/tunnel-api/tunnel-api.go:37:		NewTunnelAPIOptions							0.0%
github.com/konveyor/crane/cmd/tunnel-api/tunnel-api.go:66:		addFlagsForTunnelAPIOptions						0.0%
github.com/konveyor/crane/cmd/tunnel-api/tunnel-api.go:78:		Complete								0.0%
github.com/konveyor/crane/cmd/tunnel-api/tunnel-api.go:103:		Validate								0.0%
github.com/konveyor/crane/cmd/tunnel-api/tunnel-api.go:124:		Run									0.0%
github.com/konveyor/crane/cmd/tunnel-api/tunnel-api.go:128:		getClientFromContext							0.0%
github.com/konveyor/crane/cmd/tunnel-api/tunnel-api.go:137:		getRestConfigFromContext						0.0%
github.com/konveyor/crane/cmd/tunnel-api/tunnel-api.go:144:		run									0.0%
github.com/konveyor/crane/cmd/validate/validate.go:39:			Complete								92.3%
github.com/konveyor/crane/cmd/validate/validate.go:62:			determineClusterContext							91.7%
github.com/konveyor/crane/cmd/validate/validate.go:90:			Validate								100.0%
github.com/konveyor/crane/cmd/validate/validate.go:147:			Run									16.9%
github.com/konveyor/crane/cmd/validate/validate.go:264:			NewValidateCommand							47.6%
github.com/konveyor/crane/cmd/version/version.go:20:			Complete								0.0%
github.com/konveyor/crane/cmd/version/version.go:25:			Validate								0.0%
github.com/konveyor/crane/cmd/version/version.go:30:			Run									0.0%
github.com/konveyor/crane/cmd/version/version.go:34:			NewVersionCommand							0.0%
github.com/konveyor/crane/cmd/version/version.go:60:			run									100.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:21:			CreateTempDir								100.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:28:			ListFilesRecursively							91.7%
github.com/konveyor/crane/e2e-tests/utils/utils.go:51:			ListFilesRecursivelyAsList						80.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:75:			HasFilesRecursively							80.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:86:			ReadTestdataFile							88.9%
github.com/konveyor/crane/e2e-tests/utils/utils.go:105:			TestdataFilePath							0.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:125:			GoldenManifestsDir							90.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:147:			GoldenManifestsDirForPlatform						0.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:170:			CompareDirectoryFileSets						78.9%
github.com/konveyor/crane/e2e-tests/utils/utils.go:204:			compareDirectoryYAMLSemanticsWithFunc					82.4%
github.com/konveyor/crane/e2e-tests/utils/utils.go:233:			CompareDirectoryYAMLSemantics						100.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:239:			sortTopLevelArray							88.9%
github.com/konveyor/crane/e2e-tests/utils/utils.go:255:			compareYAMLFileBytesUnordered						88.2%
github.com/konveyor/crane/e2e-tests/utils/utils.go:289:			CompareDirectoryYAMLSemanticsUnordered					100.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:299:			CompareDirectoryYAMLSemanticsExport					100.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:307:			CompareDirectoryYAMLSemanticsExportAllowOptionalOCPOutputDefaults	100.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:311:			compareDirectoryYAMLSemanticsExport					92.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:390:			isOptionalOCPOutputIdentity						100.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:417:			buildNormalizedExportIndex						73.9%
github.com/konveyor/crane/e2e-tests/utils/utils.go:460:			canonicalizeDocs							87.5%
github.com/konveyor/crane/e2e-tests/utils/utils.go:474:			extractResourceIdentity							79.5%
github.com/konveyor/crane/e2e-tests/utils/utils.go:545:			parseYAMLDocuments							100.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:561:			canonicalOpenShiftDockercfgSecretName					80.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:577:			compareYAMLFileBytes							100.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:604:			AssertNoKindsInOutput							0.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:660:			AssertKindsInOutput							0.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:712:			LooksLikeYAMLFile							100.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:726:			normalizeUnstableFields							73.1%
github.com/konveyor/crane/e2e-tests/utils/utils.go:842:			stripPodTemplateHash							0.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:850:			normalizePodServiceAccountVolumeNames					90.9%
github.com/konveyor/crane/e2e-tests/utils/utils.go:907:			normalizeServiceAccountDockercfgReferences				94.1%
github.com/konveyor/crane/e2e-tests/utils/utils.go:941:			normalizeWithPath							81.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:984:			shouldDropField								100.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:1040:		AssertWhiteoutResourceFilesExist					0.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:1080:		AssertWhiteoutResourceFileCount						0.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:1112:		AssertWhiteoutCommentsInKustomization					0.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:1167:		AssertKindsNotInActiveKustomizeResources				0.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:1209:		CaptureAPISurfaceScriptPath						75.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:1228:		ToInt64									0.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:1245:		ExtractCPUAverageUtilization						0.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:1278:		AssertFilesExist							0.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:1304:		RemapNamespaceInYAML							0.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:1332:		ParseValidationReport							0.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:1381:		getPrefixAndSuffix							100.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:1400:		fileHasPrefixAndSuffix							100.0%
github.com/konveyor/crane/e2e-tests/utils/utils.go:1408:		AssertResourcesExist							92.3%
github.com/konveyor/crane/e2e-tests/utils/utils.go:1430:		AssertResourcesDontExist						84.6%
github.com/konveyor/crane/e2e-tests/utils/utils_validate.go:34:		VerifyValidateResults							0.0%
github.com/konveyor/crane/internal/apply/kustomize.go:31:		ApplySingleStage							0.0%
github.com/konveyor/crane/internal/apply/kustomize.go:89:		ApplyMultiStage								0.0%
github.com/konveyor/crane/internal/apply/kustomize.go:153:		runKustomizeBuild							0.0%
github.com/konveyor/crane/internal/apply/kustomize.go:162:		filterClusterScopedResources						70.0%
github.com/konveyor/crane/internal/apply/kustomize.go:224:		splitMultiDocYAMLToFiles						77.4%
github.com/konveyor/crane/internal/audit/audit_logger.go:21:		NewFileHook								77.8%
github.com/konveyor/crane/internal/audit/audit_logger.go:42:		Levels									100.0%
github.com/konveyor/crane/internal/audit/audit_logger.go:54:		Fire									86.7%
github.com/konveyor/crane/internal/audit/audit_logger.go:77:		Close									100.0%
github.com/konveyor/crane/internal/audit/audit_logger.go:91:		NewConsoleHook								100.0%
github.com/konveyor/crane/internal/audit/audit_logger.go:109:		Levels									100.0%
github.com/konveyor/crane/internal/audit/audit_logger.go:113:		Fire									66.7%
github.com/konveyor/crane/internal/buildinfo/buildinfo.go:25:		readKustomizeVersion							100.0%
github.com/konveyor/crane/internal/cli/banner.go:8:			PrintTransferBanner							100.0%
github.com/konveyor/crane/internal/cli/phase.go:17:			NewPhaseTracker								100.0%
github.com/konveyor/crane/internal/cli/phase.go:25:			Start									100.0%
github.com/konveyor/crane/internal/cli/phase.go:31:			End									100.0%
github.com/konveyor/crane/internal/cli/phase.go:39:			Fail									100.0%
github.com/konveyor/crane/internal/cli/phase.go:45:			Elapsed									100.0%
github.com/konveyor/crane/internal/cli/summary.go:14:			PrintTransferSummary							100.0%
github.com/konveyor/crane/internal/file/file_helper.go:23:		ReadFiles								100.0%
github.com/konveyor/crane/internal/file/file_helper.go:29:		ReadFilesWithLogger							100.0%
github.com/konveyor/crane/internal/file/file_helper.go:40:		readFiles								84.6%
github.com/konveyor/crane/internal/file/file_helper.go:100:		GetWhiteOutFilePath							100.0%
github.com/konveyor/crane/internal/file/file_helper.go:104:		GetTransformPath							100.0%
github.com/konveyor/crane/internal/file/file_helper.go:108:		updateTransformDirPath							100.0%
github.com/konveyor/crane/internal/file/file_helper.go:112:		updatePath								100.0%
github.com/konveyor/crane/internal/file/file_helper.go:119:		GetOutputFilePath							100.0%
github.com/konveyor/crane/internal/file/file_helper.go:129:		GetStageDir								100.0%
github.com/konveyor/crane/internal/file/file_helper.go:135:		GetInputDir								100.0%
github.com/konveyor/crane/internal/file/file_helper.go:141:		GetNewResourcesDir							0.0%
github.com/konveyor/crane/internal/file/file_helper.go:147:		GetPatchesDir								100.0%
github.com/konveyor/crane/internal/file/file_helper.go:153:		GetKustomizationPath							100.0%
github.com/konveyor/crane/internal/file/file_helper.go:159:		GetMetadataPath								100.0%
github.com/konveyor/crane/internal/file/file_helper.go:165:		GetResourceTypeFilePath							100.0%
github.com/konveyor/crane/internal/file/file_helper.go:171:		GetPatchFilePath							100.0%
github.com/konveyor/crane/internal/file/file_helper.go:178:		GetStageTransformDir							0.0%
github.com/konveyor/crane/internal/file/file_helper.go:184:		GetStageOutputDir							0.0%
github.com/konveyor/crane/internal/file/file_helper.go:191:		sanitizeFilename							100.0%
github.com/konveyor/crane/internal/file/file_helper.go:209:		GetResourceFilename							100.0%
github.com/konveyor/crane/internal/file/ordering.go:82:			GetResourceOrder							100.0%
github.com/konveyor/crane/internal/file/ordering.go:92:			GetOrderedResourceFilename						100.0%
github.com/konveyor/crane/internal/flags/global_flags.go:23:		ApplyFlags								0.0%
github.com/konveyor/crane/internal/flags/global_flags.go:32:		SetCmdName								0.0%
github.com/konveyor/crane/internal/flags/global_flags.go:39:		GetLoggerOrDefault							0.0%
github.com/konveyor/crane/internal/flags/global_flags.go:48:		isCompletionMode							0.0%
github.com/konveyor/crane/internal/flags/global_flags.go:52:		GetLogger								0.0%
github.com/konveyor/crane/internal/flags/global_flags.go:73:		Close									0.0%
github.com/konveyor/crane/internal/flags/global_flags.go:80:		initConfig								0.0%
github.com/konveyor/crane/internal/flags/help_groups.go:12:		KubernetesClientInheritedFlagNames					0.0%
github.com/konveyor/crane/internal/flags/help_groups.go:40:		SetGroupedHelp								0.0%
github.com/konveyor/crane/internal/kustomize/args.go:20:		ParseAndValidateArgs							100.0%
github.com/konveyor/crane/internal/kustomize/args.go:92:		splitArgs								100.0%
github.com/konveyor/crane/internal/kustomize/runner.go:21:		Build									69.6%
github.com/konveyor/crane/internal/kustomize/runner.go:61:		buildOptions								100.0%
github.com/konveyor/crane/internal/kustomize/runner.go:115:		setEnvVars								46.2%
github.com/konveyor/crane/internal/log/controller_runtime.go:14:	InitControllerRuntimeLogger						0.0%
github.com/konveyor/crane/internal/plugin/plugin_helper.go:21:		GetPlugins								0.0%
github.com/konveyor/crane/internal/plugin/plugin_helper.go:38:		getBinaryPlugins							0.0%
github.com/konveyor/crane/internal/plugin/plugin_helper.go:63:		IsExecAny								0.0%
github.com/konveyor/crane/internal/plugin/plugin_helper.go:67:		GetFilteredPlugins							0.0%
github.com/konveyor/crane/internal/plugin/plugin_helper.go:109:		isPluginInList								0.0%
github.com/konveyor/crane/internal/plugin/plugin_manager_helper.go:24:	BuildManifestMap							0.0%
github.com/konveyor/crane/internal/plugin/plugin_manager_helper.go:69:	GetYamlFromUrl								75.0%
github.com/konveyor/crane/internal/plugin/plugin_manager_helper.go:83:	YamlToManifest								72.7%
github.com/konveyor/crane/internal/plugin/plugin_manager_helper.go:105:	FilterPluginForOsArch							100.0%
github.com/konveyor/crane/internal/plugin/plugin_manager_helper.go:120:	GetDefaultSource							0.0%
github.com/konveyor/crane/internal/plugin/plugin_manager_helper.go:129:	LocateBinaryInPluginDir							0.0%
github.com/konveyor/crane/internal/plugin/plugin_manager_helper.go:141:	IsUrl									100.0%
github.com/konveyor/crane/internal/plugin/plugin_manager_helper.go:147:	getData									80.0%
github.com/konveyor/crane/internal/transform/instructions.go:43:	UnmarshalYAML								90.5%
github.com/konveyor/crane/internal/transform/instructions.go:88:	LoadInstructions							76.5%
github.com/konveyor/crane/internal/transform/instructions.go:119:	friendlyInstructionsDecodeError						100.0%
github.com/konveyor/crane/internal/transform/instructions.go:134:	ValidateInstructions							100.0%
github.com/konveyor/crane/internal/transform/instructions.go:167:	StageNames								100.0%
github.com/konveyor/crane/internal/transform/instructions.go:177:	StageOptionals								100.0%
github.com/konveyor/crane/internal/transform/instructions.go:197:	GenerateStageDirNames							100.0%
github.com/konveyor/crane/internal/transform/orchestrator.go:48:	validateStageOptionalFlags						100.0%
github.com/konveyor/crane/internal/transform/orchestrator.go:69:	resolveOptionalFlags							100.0%
github.com/konveyor/crane/internal/transform/orchestrator.go:92:	RunMultiStage								63.2%
github.com/konveyor/crane/internal/transform/orchestrator.go:207:	executeStage								59.1%
github.com/konveyor/crane/internal/transform/orchestrator.go:257:	transformResources							73.7%
github.com/konveyor/crane/internal/transform/orchestrator.go:351:	formatResourceID							0.0%
github.com/konveyor/crane/internal/transform/orchestrator.go:358:	getPluginForStage							83.3%
github.com/konveyor/crane/internal/transform/orchestrator.go:386:	getAvailablePluginNames							0.0%
github.com/konveyor/crane/internal/transform/orchestrator.go:399:	applyStageTransforms							71.4%
github.com/konveyor/crane/internal/transform/orchestrator.go:473:	loadResourcesFromDirectory						75.0%
github.com/konveyor/crane/internal/transform/orchestrator.go:489:	writeResourcesToDirectory						61.3%
github.com/konveyor/crane/internal/transform/stages.go:22:		DiscoverStages								90.5%
github.com/konveyor/crane/internal/transform/stages.go:83:		FilterStages								100.0%
github.com/konveyor/crane/internal/transform/stages.go:112:		GetFirstStage								100.0%
github.com/konveyor/crane/internal/transform/stages.go:122:		GetLastStage								66.7%
github.com/konveyor/crane/internal/transform/stages.go:132:		GetPreviousStage							100.0%
github.com/konveyor/crane/internal/transform/stages.go:142:		GetNextStage								100.0%
github.com/konveyor/crane/internal/transform/stages.go:152:		ValidateStageName							100.0%
github.com/konveyor/crane/internal/transform/stages.go:161:		GenerateStageName							100.0%
github.com/konveyor/crane/internal/transform/test_helpers.go:8:		hasKustomizeCommand							100.0%
github.com/konveyor/crane/internal/transform/test_helpers.go:14:	contains								100.0%
github.com/konveyor/crane/internal/transform/test_helpers.go:23:	findInString								100.0%
github.com/konveyor/crane/internal/transform/writer.go:27:		NewKustomizeWriter							100.0%
github.com/konveyor/crane/internal/transform/writer.go:36:		WriteStage								67.0%
github.com/konveyor/crane/internal/transform/writer.go:254:		getResourceID								100.0%
github.com/konveyor/crane/internal/transform/writer.go:267:		filterValidRemoveOps							76.2%
github.com/konveyor/crane/internal/transform/writer.go:311:		pathExists								93.5%
github.com/konveyor/crane/internal/transform/writer.go:388:		generateKustomizationWithComments					88.2%
github.com/konveyor/crane/internal/transform/writer.go:420:		checkStageDirectory							17.6%
github.com/konveyor/crane/internal/validate/api_resources.go:24:	ParseAPIResourcesJSON							88.2%
github.com/konveyor/crane/internal/validate/matcher.go:25:		MatchResults								75.0%
github.com/konveyor/crane/internal/validate/matcher.go:36:		MatchResultsFromIndex							100.0%
github.com/konveyor/crane/internal/validate/matcher.go:76:		buildDiscoveryIndex							62.5%
github.com/konveyor/crane/internal/validate/matcher.go:113:		matchEntry								100.0%
github.com/konveyor/crane/internal/validate/matcher.go:142:		buildKindIndex								100.0%
github.com/konveyor/crane/internal/validate/matcher.go:154:		addSuggestion								91.7%
github.com/konveyor/crane/internal/validate/report.go:17:		FormatTable								91.3%
github.com/konveyor/crane/internal/validate/report.go:60:		FormatJSON								100.0%
github.com/konveyor/crane/internal/validate/report.go:67:		FormatYAML								0.0%
github.com/konveyor/crane/internal/validate/report.go:79:		WriteFailures								0.0%
github.com/konveyor/crane/internal/validate/report.go:118:		failureFileName								0.0%
github.com/konveyor/crane/internal/validate/report.go:132:		safeFilePart								0.0%
github.com/konveyor/crane/internal/validate/report.go:148:		parseAPIVersion								0.0%
github.com/konveyor/crane/internal/validate/scanner.go:34:		ScanManifests								72.2%
github.com/konveyor/crane/internal/validate/types.go:46:		HasIncompatible								100.0%
github.com/konveyor/crane/internal/validate/types.go:49:		IncompatibleResults							0.0%
github.com/konveyor/crane/main.go:23:					main									0.0%
github.com/konveyor/crane/main.go:27:					run									0.0%
total:									(statements)								50.2%

Posted by CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant