🐛 Fix per-stage optionals in instructions file - #940
Open
aufi wants to merge 1 commit into
Open
Conversation
Limit transform instruction-file optionals to the stage currently being executed, preventing validation failures for optionals configured on other stages. Add regression coverage for stage-specific optional flag isolation. Fixes migtools#925 Signed-off-by: Marek Aufart <maufart@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe transform command now preserves instruction plugin names separately from generated stage directory names. Each instruction stage runs with only its matching optional flags. Tests cover Kubernetes, OpenShift, and stages without optionals. ChangesInstructions-file stage optionals
Priority: ➖ Normal — Impact reflects medium issue severity. Estimated code review effort: 2 (Simple) | ~10 minutes Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to Instruction-file transforms now pass each plugin only its own optional values, allowing multi-stage pipelines with distinct plugin options to run without cross-stage validation failures. No current merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Test Coverage ReportTotal: 49.8% Per-package coverage
Full function-level detailsPosted by CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limit transform instruction-file optionals to the stage currently being executed, preventing validation failures for optionals configured on other stages.
Add regression coverage for stage-specific optional flag isolation.
Fixes #925
Summary by CodeRabbit
Bug Fixes
Tests